From patchwork Tue Oct 30 16:16:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pawel Moll X-Patchwork-Id: 1671081 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 51BD73FD2B for ; Tue, 30 Oct 2012 16:19:38 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TTEV9-0006dq-1Q; Tue, 30 Oct 2012 16:17:15 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TTEV0-0006cH-W8 for linux-arm-kernel@lists.infradead.org; Tue, 30 Oct 2012 16:17:11 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 30 Oct 2012 16:17:02 +0000 Received: from [10.1.205.147] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 30 Oct 2012 16:16:57 +0000 Message-ID: <1351613819.6199.14.camel@hornet> Subject: Re: vexpress issues in next-20121029 From: Pawel Moll To: Stephen Warren Date: Tue, 30 Oct 2012 16:16:59 +0000 In-Reply-To: <508EE610.9050703@wwwdotorg.org> References: <508EE610.9050703@wwwdotorg.org> X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 X-OriginalArrivalTime: 30 Oct 2012 16:16:57.0070 (UTC) FILETIME=[FBA4D0E0:01CDB6B9] X-MC-Unique: 112103016170206801 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: ARM kernel mailing list X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Stephen, On Mon, 2012-10-29 at 20:24 +0000, Stephen Warren wrote: > 1) At compile-time: v2m_timer_init() and v2m_dt_timer_init() reference > functions vexpress_clk_init() and vexpress_clk_of_init() respectively, > which don't appear anywhere in the source tree. There was a glitch between clk-next and arm-soc - it should be fine starting with next-20121030. > 2) With those calls commented out, I find that > vexpress_sysreg_init_leds() is device_initcall, and so executes even > when not running on vexpress HW. This crashes on Tegra (which I have > converted to single-zImage locally). Uh, how stupid of me! I have to finally get used to the new multi-platform-kernel reality... Sorry about it - a quick workaround would be: 8<---------------------------- 8<---------------------------- while I'm improving the situation by better means. Sorry about this and thanks for letting me know! Pawe? diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index 059d6b1..99e89a8 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -474,7 +474,6 @@ static int __init vexpress_sysreg_init(void) } core_initcall(vexpress_sysreg_init); - #if defined(CONFIG_LEDS_CLASS) struct vexpress_sysreg_led { @@ -526,6 +525,9 @@ static int __init vexpress_sysreg_init_leds(void) struct vexpress_sysreg_led *led; int i; + if (!vexpress_sysreg_base) + return 0; + /* Clear all user LEDs */ writel(0, vexpress_sysreg_base + SYS_LED);