| Message ID | 1352101183-20606-1-git-send-email-plagnioj@jcrosoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 05, 2012 at 08:39:43AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > if the gpio is not valid complain > > since 3285e0ec088febc5a88f57ddd78385a7da71476c > ARM: at91/udc: use gpio_is_valid to check the gpio > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> > Cc: linux-usb@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > Hi Greg, > > this is broken since 3.2 can we have on the stable too Sure, but you should be sending gadget patches to Felipe, not me, as he's in charge of that tree. So I suggest you resend this, cc: Felipe and add the proper stable tree marking to the Cc: area of the signed-off-by: part of the patch, like the file Documentation/stable_kernel_rules.txt describes to do. That way it will be picked up automatically for the stable releases when it gets in to Linus's tree. thanks, greg k-h
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index 89d90b5..888cb2a 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -1739,7 +1739,7 @@ static int __devinit at91udc_probe(struct platform_device *pdev) /* rm9200 needs manual D+ pullup; off by default */ if (cpu_is_at91rm9200()) { - if (gpio_is_valid(udc->board.pullup_pin)) { + if (!gpio_is_valid(udc->board.pullup_pin)) { DBG("no D+ pullup?\n"); retval = -ENODEV; goto fail0;
if the gpio is not valid complain since 3285e0ec088febc5a88f57ddd78385a7da71476c ARM: at91/udc: use gpio_is_valid to check the gpio Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Cc: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> --- Hi Greg, this is broken since 3.2 can we have on the stable too Best Regards, J. drivers/usb/gadget/at91_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)