From patchwork Thu Nov 8 19:08:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1716981 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 582C43FCDE for ; Thu, 8 Nov 2012 19:11:02 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWXTF-0001Nh-Kc; Thu, 08 Nov 2012 19:08:57 +0000 Received: from mail-da0-f49.google.com ([209.85.210.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TWXTC-0001ND-AH for linux-arm-kernel@lists.infradead.org; Thu, 08 Nov 2012 19:08:55 +0000 Received: by mail-da0-f49.google.com with SMTP id q27so1213328daj.36 for ; Thu, 08 Nov 2012 11:08:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=eFjpf4CfNni/HerTezXfTruVv2/G9YLYG5VIwo7P2+k=; b=kj55d1NB64Warwk21KZL7Xlqq4TgdWxon/aT0O3w/i8zWQMd+9O0sR2Q1JV7tCRY14 YpT7XwWr709fbJgz4J2WmKiv00FbYn5PZcICztP0wLDKutqTv0ujt3awD8zsRhUfak8Q +QSK/ufPnYWvQDTM8ImB6JxONCmcO69ZWp3/HpJ1CQLVY23SIzC74876PNVXoX9h2ZCo aYwd94pFnJB+rZlMhJe7IapPNZIX2E0/fgf6dgn9yZkfE2aa6u6D8jPtZuCfyKPS59FE igxiONVW+gt3FO5nUSvXzwWpSi7oTao3T2mN9MzCuWfqfpDk1hYwVa3vMeLLJenNyHrW NoIQ== Received: by 10.68.204.103 with SMTP id kx7mr20232014pbc.33.1352401732332; Thu, 08 Nov 2012 11:08:52 -0800 (PST) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id vi9sm16347959pbc.41.2012.11.08.11.08.51 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 11:08:51 -0800 (PST) From: Kevin Hilman To: Tony Lindgren , linux-omap@vger.kernel.org Subject: [PATCH] ARM: OMAP4: TWL: mux sys_drm_msecure as output for PMIC Date: Thu, 8 Nov 2012 11:08:50 -0800 Message-Id: <1352401730-4269-1-git-send-email-khilman@deeprootsystems.com> X-Mailer: git-send-email 1.8.0 X-Gm-Message-State: ALoCoQlaMJrXh2qh13yyh1kJg6txZqVcsIvfpEGPpdmVDnGNvKRB0FwmOiNTjo+y3LYW+JM6j2wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121108_140854_474474_03C2665D X-CRM114-Status: GOOD ( 13.11 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Kevin Hilman On OMAP4 boards using the TWL6030 PMIC, the sys_drm_msecure is connected to the MSECURE input of the TWL6030 PMIC. This signal controls the secure-mode operation of the PMIC. If its not mux'd correctly, some functionality of the PMIC will not be accessible since the PMIC will be in secure mode. For example, if the TWL RTC is in secure mode, most of its registers are read-only, meaning (re)programming the RTC (e.g. for wakeup from suspend) will fail. To fix, ensure the signal is properly mux'd as output when TWL is intialized. This fix is required when using recent versions of u-boot (>= v2012.04.01) since u-boot is no longer setting the default mux for this pin. Signed-off-by: Kevin Hilman --- Based on v3.7-rc4. Targetted as a fix for v3.7. A correponding DT fix for this is needed as well, but that will be part of a bigger series to get PM working with DT boot and needs to include other pins like sys_nirq1. arch/arm/mach-omap2/twl-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c index 635e109..96cae8b 100644 --- a/arch/arm/mach-omap2/twl-common.c +++ b/arch/arm/mach-omap2/twl-common.c @@ -73,6 +73,7 @@ void __init omap4_pmic_init(const char *pmic_type, { /* PMIC part*/ omap_mux_init_signal("sys_nirq1", OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE); + omap_mux_init_signal("fref_clk0_out.sys_drm_msecure", OMAP_PIN_OUTPUT); omap_pmic_init(1, 400, pmic_type, 7 + OMAP44XX_IRQ_GIC_START, pmic_data); /* Register additional devices on i2c1 bus if needed */