diff mbox

ARM: shmobile: mackerel: Add FLCTL IRQ resource

Message ID 1353288254-6211-2-git-send-email-horms@verge.net.au (mailing list archive)
State New, archived
Headers show

Commit Message

Simon Horman Nov. 19, 2012, 1:24 a.m. UTC 
From: Bastian Hecht <hechtb@gmail.com>

Since commit 3c7ea4eccfd2e the sh_flctl driver requires the error IRQ line to
signal failed transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start up. We
provide it here for the board mackerel.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Sergei Shtylyov Nov. 19, 2012, 12:30 p.m. UTC | #1 
Hello.

On 19-11-2012 5:24, Simon Horman wrote:

> From: Bastian Hecht <hechtb@gmail.com>

> Since commit 3c7ea4eccfd2e

    Please also specify that commit summary in parens.

> the sh_flctl driver requires the error IRQ line to
> signal failed transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start up. We
> provide it here for the board mackerel.

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>

WBR, Sergei
Simon Horman Nov. 20, 2012, 12:03 a.m. UTC | #2 
On Mon, Nov 19, 2012 at 04:30:59PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 19-11-2012 5:24, Simon Horman wrote:
> 
> >From: Bastian Hecht <hechtb@gmail.com>
> 
> >Since commit 3c7ea4eccfd2e
> 
>    Please also specify that commit summary in parens.

Thanks, I will fix this and re-post.

> >the sh_flctl driver requires the error IRQ line to
> >signal failed transactions between the flash controller and the NAND chip.
> >This information is mandatory - else the driver refuses to start up. We
> >provide it here for the board mackerel.
> 
> >Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
diff mbox

Patch

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@  static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {