From patchwork Tue Nov 20 01:05:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Ramirez Luna X-Patchwork-Id: 1770061 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 593173FCDE for ; Tue, 20 Nov 2012 01:08:46 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TacI8-0007Ep-9y; Tue, 20 Nov 2012 01:06:20 +0000 Received: from mail-oa0-f49.google.com ([209.85.219.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TacHw-0007D0-3P for linux-arm-kernel@lists.infradead.org; Tue, 20 Nov 2012 01:06:08 +0000 Received: by mail-oa0-f49.google.com with SMTP id l10so5333181oag.36 for ; Mon, 19 Nov 2012 17:06:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=9Rt/QgefyuycjZmMweiSNV7mH8L/yEzVNFPEtfFG8pM=; b=FONLhmN3wrQqhfarhHWnzn89UVG789tggjyYSqgKUhh3zlWyb6vlKW38cHGzMZEs17 CCdGSLnlxQXUzJfz6Cn0C6Bsxlt3MXSeRKqLUoTt7tG4pVWTiYuRMXOxNqupB+K9mgnF F3KAE/t8UwnX1gLHBAdvOiRhO0IjG3xGcyXN9pDfRLGNacPW+j5L7WHJ5zk+uFsEeYlH UL15IMXyCQhK882I93OFd8j0Wzxyv4YWhq2wY1mWsEGJVhETr2ejW6kTdnR6hvHeDqAD p0i7UiFoj1l+bK6Y89KRCZ4yb6YRMpj/ZaY6LDvqxPd3zrTDAs0rVcknJDkTXQu5WrJD rgtA== Received: by 10.60.14.200 with SMTP id r8mr12297321oec.45.1353373567813; Mon, 19 Nov 2012 17:06:07 -0800 (PST) Received: from localhost.localdomain (dragon.ti.com. [192.94.94.33]) by mx.google.com with ESMTPS id vt9sm11578237obb.3.2012.11.19.17.06.06 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Nov 2012 17:06:06 -0800 (PST) From: Omar Ramirez Luna To: Tony Lindgren , Joerg Roedel Subject: [PATCH v5 1/5] iommu/omap: remove redundant clock handling on ISR Date: Mon, 19 Nov 2012 19:05:48 -0600 Message-Id: <1353373552-16039-2-git-send-email-omar.luna@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353373552-16039-1-git-send-email-omar.luna@linaro.org> References: <1353373552-16039-1-git-send-email-omar.luna@linaro.org> X-Gm-Message-State: ALoCoQlxAjik2TZgQUNljSItmVOjmfShtkZscQI4YL+kfQUN5Jixx3DTArS5kYHRDPYxGf2ILlBc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121119_200608_290082_FCBC1EAD X-CRM114-Status: GOOD ( 13.96 ) X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.219.49 listed in list.dnswl.org] 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Ohad Ben-Cohen , Paul Walmsley , Russell King , Mauro Carvalho Chehab , Felipe Contreras , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Omar Ramirez Luna , linux-omap@vger.kernel.org, Ido Yariv , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org For the interrupt to be generated, the mmu clock should be already enabled while translating a virtual address, so, this call to clock handling is just increasing/decreasing the counter. This works now, because its users need the same clock and they indirectly power the mmu, in this interrupt context the handling of clocks inside the ISR doesn't seem to be needed nor helping. Next patch should also correct the dependency on clients to handle iommu clocks. Signed-off-by: Omar Ramirez Luna --- drivers/iommu/omap-iommu.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index badc17c..6b1288c 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -807,9 +807,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data) if (!obj->refcount) return IRQ_NONE; - clk_enable(obj->clk); errs = iommu_report_fault(obj, &da); - clk_disable(obj->clk); if (errs == 0) return IRQ_HANDLED;