| Message ID | 1353503469-18634-11-git-send-email-avinashphilip@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 21, 2012 at 06:41:07PM +0530, Philip, Avinash wrote: [...] > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts > index 9f65f17..4178ba4 100644 > --- a/arch/arm/boot/dts/am335x-evm.dts > +++ b/arch/arm/boot/dts/am335x-evm.dts > @@ -44,6 +44,12 @@ > 0x154 0x27 /* spi0_d0.gpio0_3, INPUT | MODE7 */ > >; > }; > + > + ecap0_pins: backlight_pins { > + pinctrl-single,pins = < > + 0x164 0x0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ > + >; This looks kind of funky, but I see the rest of the file uses similar formatting, so I guess it's okay. > @@ -158,6 +174,13 @@ > gpio-key,wakeup; > }; > }; > + > + backlight { > + compatible = "pwm-backlight"; Maybe you don't want a tab between "compatible" and "=", but a space instead. Other than that, looks good: Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
On Fri, Nov 23, 2012 at 02:41:47, Thierry Reding wrote: > On Wed, Nov 21, 2012 at 06:41:07PM +0530, Philip, Avinash wrote: > [...] > > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts > > index 9f65f17..4178ba4 100644 > > --- a/arch/arm/boot/dts/am335x-evm.dts > > +++ b/arch/arm/boot/dts/am335x-evm.dts > > @@ -44,6 +44,12 @@ > > 0x154 0x27 /* spi0_d0.gpio0_3, INPUT | MODE7 */ > > >; > > }; > > + > > + ecap0_pins: backlight_pins { > > + pinctrl-single,pins = < > > + 0x164 0x0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ > > + >; > > This looks kind of funky, but I see the rest of the file uses similar > formatting, so I guess it's okay. > > > @@ -158,6 +174,13 @@ > > gpio-key,wakeup; > > }; > > }; > > + > > + backlight { > > + compatible = "pwm-backlight"; > > Maybe you don't want a tab between "compatible" and "=", but a space > instead. I will correct it. Thanks Avinash > > Other than that, looks good: > > Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de> >
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 9f65f17..4178ba4 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -44,6 +44,12 @@ 0x154 0x27 /* spi0_d0.gpio0_3, INPUT | MODE7 */ >; }; + + ecap0_pins: backlight_pins { + pinctrl-single,pins = < + 0x164 0x0 /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */ + >; + }; }; ocp { @@ -102,6 +108,16 @@ reg = <0x48>; }; }; + + epwmss0: epwmss@48300000 { + status = "okay"; + + ecap0: ecap@48300100 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&ecap0_pins>; + }; + }; }; vbat: fixedregulator@0 { @@ -158,6 +174,13 @@ gpio-key,wakeup; }; }; + + backlight { + compatible = "pwm-backlight"; + pwms = <&ecap0 0 50000 0>; + brightness-levels = <0 51 53 56 62 75 101 152 255>; + default-brightness-level = <8>; + }; }; /include/ "tps65910.dtsi"
PWM output from ecap0 uses as backlight source. Also adds low threshold value to have a uniform divisions in brightness-levels scales. Signed-off-by: Philip, Avinash <avinashphilip@ti.com> --- Changes since v3: - Add epwmss parent status="okay" field. :100644 100644 9f65f17... 4178ba4c.. M arch/arm/boot/dts/am335x-evm.dts arch/arm/boot/dts/am335x-evm.dts | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)