From patchwork Mon Nov 26 09:20:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Hesselbarth X-Patchwork-Id: 1801171 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id E6EC93FC23 for ; Mon, 26 Nov 2012 09:24:04 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tcus8-0002jr-KJ; Mon, 26 Nov 2012 09:21:00 +0000 Received: from mail-bk0-f49.google.com ([209.85.214.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tcus0-0002el-8R for linux-arm-kernel@lists.infradead.org; Mon, 26 Nov 2012 09:20:53 +0000 Received: by mail-bk0-f49.google.com with SMTP id jm19so3183665bkc.36 for ; Mon, 26 Nov 2012 01:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=IBAtHwl9TbKDsN4v/53qASydKTbDSUjIVzCCmVFsRNk=; b=qpO20o0i0U7USm1NGhajn87lI9rIasEIV+89naXsb4Ta8cTwSTCktw4vXomltQaUTQ o0fPQaZQwfB0/LEgpX8E4/UfxZtvzMbbDLu+ffsQXzzi3CzIpLWjKlGypxXslRgXWOPH dCXdEa4hbPxoLnTbAHqnv0BU0h06YhUMTQ6M2DX8kCVNaBziVtXC4Cjqx6PGJDma273S OMH8XwL4AZKN+FU2Zsf5V0AxJa2qD3DamAVDHprAKves1NMxKp1IAVIf/lGfAGIE6yFf Npzvc8NgHvL8Yb2KTZ1yvJ7Jb3kEUNX5hfUImHS4c0A9S3+dXZLW1p6toorze4YY3DBs gjAQ== Received: by 10.204.10.88 with SMTP id o24mr1983490bko.19.1353921650896; Mon, 26 Nov 2012 01:20:50 -0800 (PST) Received: from nijin.lan (dslc-082-083-245-055.pools.arcor-ip.net. [82.83.245.55]) by mx.google.com with ESMTPS id 1sm7303599bks.3.2012.11.26.01.20.42 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Nov 2012 01:20:49 -0800 (PST) From: Sebastian Hesselbarth To: Sebastian Hesselbarth Subject: [PATCH 2/2] pinctrl: mvebu: make pdma clock on dove mandatory Date: Mon, 26 Nov 2012 10:20:34 +0100 Message-Id: <1353921634-25210-1-git-send-email-sebastian.hesselbarth@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1353921525-25163-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1353921525-25163-1-git-send-email-sebastian.hesselbarth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121126_042052_681555_573F2B66 X-CRM114-Status: GOOD ( 13.17 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sebastian.hesselbarth[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Thomas Petazzoni , Andrew Lunn , Axel Lin , Jason Cooper , Linus Walleij , linux-kernel@vger.kernel.org, Gregory CLEMENT , Russell King , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org With the ability to pass clocks through DT, now make the pdma clock of dove pinctrl mandatory. Otherwise, pinctrl will hang the system when accessing some registers. Signed-off-by: Sebastian Hesselbarth --- Cc: Jason Cooper Cc: Sebastian Hesselbarth Cc: Thomas Petazzoni Cc: Andrew Lunn Cc: Gregory CLEMENT Cc: Axel Lin Cc: Linus Walleij Cc: Russell King Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/pinctrl/mvebu/pinctrl-dove.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 40c9c3e..90f257d 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c @@ -595,8 +595,11 @@ static int __devinit dove_pinctrl_probe(struct platform_device *pdev) * grab clk to make sure it is ticking. */ clk = devm_clk_get(&pdev->dev, NULL); - if (!IS_ERR(clk)) - clk_prepare_enable(clk); + if (IS_ERR(clk)) { + dev_err(&pdev->dev, "Unable to get pdma clock"); + return -ENODEV; + } + clk_prepare_enable(clk); return mvebu_pinctrl_probe(pdev); }