From patchwork Thu Nov 29 23:00:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Cross X-Patchwork-Id: 1823191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id AF9233FC23 for ; Thu, 29 Nov 2012 23:04:18 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TeD5y-0008Vz-37; Thu, 29 Nov 2012 23:00:38 +0000 Received: from mail-wg0-f73.google.com ([74.125.82.73]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TeD5t-0008Un-1R for linux-arm-kernel@lists.infradead.org; Thu, 29 Nov 2012 23:00:35 +0000 Received: by mail-wg0-f73.google.com with SMTP id dt12so808837wgb.0 for ; Thu, 29 Nov 2012 15:00:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=gr2IC8401nt2bsZ2z6E3iRLYkzUNyoOaMVVbNgSX1BI=; b=U1qXzvrvIXlhg/doyf89RKo4cG0w30T/Na0rQgVbtOeo10PppB+2mqiu2AgjISUkEd yQSUaMZWub7gAwJM1ob8UWlKPbrYGcEmGLBbi1YtCeBlgP9Qg3lf6+WNHvuhXgrNO7Lt 1QPrpQGNGQL2H3jzlZlbBVECfWbcoUJmNq1WV22XAVh/GIvMeFBtjMS1BOMXkQu7ekR5 MV4I6pT0Rlyd+seie5vHAFAw+liEOw19gqqzDTbsaDL7Y+/FL1lWFONs7wVjdpqmvZ7v O4NPrw0GPEP/5pZm67uIgwUDwtaRuaICdIm2d/NLas4pB1WPWC1fpSgcn+Jpo7Xkrnc3 Ja8w== Received: by 10.14.216.7 with SMTP id f7mr29106308eep.4.1354230030387; Thu, 29 Nov 2012 15:00:30 -0800 (PST) Received: from hpza10.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id z47si744281eel.0.2012.11.29.15.00.30 (version=TLSv1/SSLv3 cipher=AES128-SHA); Thu, 29 Nov 2012 15:00:30 -0800 (PST) Received: from walnut.mtv.corp.google.com (walnut.mtv.corp.google.com [172.18.105.48]) by hpza10.eem.corp.google.com (Postfix) with ESMTP id 0AF5F200059; Thu, 29 Nov 2012 15:00:30 -0800 (PST) Received: by walnut.mtv.corp.google.com (Postfix, from userid 99897) id 64412160CEF; Thu, 29 Nov 2012 15:00:29 -0800 (PST) From: Colin Cross To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/3] ARM: stacktrace: enable save_stack_trace_tsk for CONFIG_SMP Date: Thu, 29 Nov 2012 15:00:27 -0800 Message-Id: <1354230027-2204-4-git-send-email-ccross@android.com> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1354230027-2204-1-git-send-email-ccross@android.com> References: <1354230027-2204-1-git-send-email-ccross@android.com> X-Gm-Message-State: ALoCoQm6eg8HvD6v5lsJC0fSiUuhgpVOoJVUFwOmxwkdtQjObHx/XpL8o4kUUUu+V6DEhT9lJtqnySiZdwtTOLGt3AdRczMHCrDZuju0pTbLDPdwXo29WZ2gjWVdY1wzOSD2k0yFhNyqm0utQ+pdoXDM+vBMDulivUASK5bGrQsbrtsJuHRRuUW6S25uZm5uyoGZ92iqhw/scbQQqFXZcs/LAynyKoCYjg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121129_180033_423703_06E0B1F8 X-CRM114-Status: GOOD ( 11.78 ) X-Spam-Score: -3.3 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.73 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Dave Martin , Laura Abbott , Catalin Marinas , Will Deacon , Rabin Vincent , Colin Cross , Russell King X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Now that unwind_frame has been hardened against invalid stacks for CONFIG_ARM_UNWIND or CONFIG_FRAME_POINTER, enable dumping the stack on non-current threads for CONFIG_SMP. Signed-off-by: Colin Cross --- arch/arm/kernel/stacktrace.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c index c5ae9be..6c00a9b 100644 --- a/arch/arm/kernel/stacktrace.c +++ b/arch/arm/kernel/stacktrace.c @@ -187,22 +187,11 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) data.skip = trace->skip; if (tsk != current) { -#ifdef CONFIG_SMP - /* - * What guarantees do we have here that 'tsk' is not - * running on another CPU? For now, ignore it as we - * can't guarantee we won't explode. - */ - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; - return; -#else data.no_sched_functions = 1; frame.fp = thread_saved_fp(tsk); frame.sp = thread_saved_sp(tsk); frame.lr = 0; /* recovered from the stack */ frame.pc = thread_saved_pc(tsk); -#endif } else { register unsigned long current_sp asm ("sp");