diff mbox

ARM: Add .smp entry for REALVIEW_EB

Message ID 1354634293-18343-1-git-send-email-steve.capper@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Capper Dec. 4, 2012, 3:18 p.m. UTC 
The REALVIEW EB board can host tiles with multiple cores thus needs to be able
to initialise SMP. There is, however, no .smp entry in the MACHINE_START
struct for REALVIEW_EB.

This patch adds the appropriate .smp entry to this struct.

Signed-off-by: Steve Capper <steve.capper@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
---
 arch/arm/mach-realview/realview_eb.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Will Deacon Dec. 5, 2012, 6:18 p.m. UTC | #1 
Hi Steve,

On Tue, Dec 04, 2012 at 03:18:13PM +0000, Steve Capper wrote:
> The REALVIEW EB board can host tiles with multiple cores thus needs to be able
> to initialise SMP. There is, however, no .smp entry in the MACHINE_START
> struct for REALVIEW_EB.
> 
> This patch adds the appropriate .smp entry to this struct.
> 
> Signed-off-by: Steve Capper <steve.capper@arm.com>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/mach-realview/realview_eb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-realview/realview_eb.c b/arch/arm/mach-realview/realview_eb.c
> index d3b3cd2..28511d4 100644
> --- a/arch/arm/mach-realview/realview_eb.c
> +++ b/arch/arm/mach-realview/realview_eb.c
> @@ -467,6 +467,7 @@ static void __init realview_eb_init(void)
>  MACHINE_START(REALVIEW_EB, "ARM-RealView EB")
>  	/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */
>  	.atag_offset	= 0x100,
> +	.smp		= smp_ops(realview_smp_ops),
>  	.fixup		= realview_fixup,
>  	.map_io		= realview_eb_map_io,
>  	.init_early	= realview_init_early,

Please can you put this in the patch system? Mainline is broken on SMP EB
without it.

Will
Steve Capper Dec. 6, 2012, 10:49 a.m. UTC | #2 
On Wed, Dec 05, 2012 at 06:18:36PM +0000, Will Deacon wrote:
> 
> Please can you put this in the patch system? Mainline is broken on SMP EB
> without it.
> 
> Will

Hi Will,
I've just put it into the system now; it has ID 7594/1.

Best,
Will Deacon Dec. 6, 2012, 10:54 a.m. UTC | #3 
On Thu, Dec 06, 2012 at 10:49:47AM +0000, Steve Capper wrote:
> On Wed, Dec 05, 2012 at 06:18:36PM +0000, Will Deacon wrote:
> > 
> > Please can you put this in the patch system? Mainline is broken on SMP EB
> > without it.
> > 
> > Will
> 
> Hi Will,
> I've just put it into the system now; it has ID 7594/1.

Thanks Steve.

Will
diff mbox

Patch

diff --git a/arch/arm/mach-realview/realview_eb.c b/arch/arm/mach-realview/realview_eb.c
index d3b3cd2..28511d4 100644
--- a/arch/arm/mach-realview/realview_eb.c
+++ b/arch/arm/mach-realview/realview_eb.c
@@ -467,6 +467,7 @@  static void __init realview_eb_init(void)
 MACHINE_START(REALVIEW_EB, "ARM-RealView EB")
 	/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */
 	.atag_offset	= 0x100,
+	.smp		= smp_ops(realview_smp_ops),
 	.fixup		= realview_fixup,
 	.map_io		= realview_eb_map_io,
 	.init_early	= realview_init_early,