| Message ID | 1356018118-29852-1-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ezequiel, Thanks for the patch. 2012/12/20 Ezequiel Garcia <ezequiel.garcia@free-electrons.com>: > IGEP v2 boards has console as ttyO2,115200n8. > It's better so simply set this as the default kernel argument > directly in the device tree board file. > > Cc: Enric Balletbo i Serra <eballetbo@gmail.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts > index e2b9849..45ffe21 100644 > --- a/arch/arm/boot/dts/omap3-igep0020.dts > +++ b/arch/arm/boot/dts/omap3-igep0020.dts > @@ -15,6 +15,10 @@ > model = "IGEPv2"; > compatible = "isee,omap3-igep0020", "ti,omap3"; > > + chosen { > + bootargs = "console=ttyO2,115200n8 earlyprintk"; > + }; > + The u-boot 'bootargs' env overwrites the one from chosen ? > leds { > compatible = "gpio-leds"; > boot { > -- > 1.7.8.6 >
Hi Ezequiel, Thanks for the patch On Fri, Dec 21, 2012 at 5:02 PM, Enric Balletbo Serra <eballetbo@gmail.com> wrote: > Hi Ezequiel, > > Thanks for the patch. > > 2012/12/20 Ezequiel Garcia <ezequiel.garcia@free-electrons.com>: >> IGEP v2 boards has console as ttyO2,115200n8. >> It's better so simply set this as the default kernel argument >> directly in the device tree board file. >> >> Cc: Enric Balletbo i Serra <eballetbo@gmail.com> >> Cc: Javier Martinez Canillas <javier@dowhile0.org> >> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> >> --- >> arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >> index e2b9849..45ffe21 100644 >> --- a/arch/arm/boot/dts/omap3-igep0020.dts >> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >> @@ -15,6 +15,10 @@ >> model = "IGEPv2"; >> compatible = "isee,omap3-igep0020", "ti,omap3"; >> >> + chosen { >> + bootargs = "console=ttyO2,115200n8 earlyprintk"; >> + }; >> + > > The u-boot 'bootargs' env overwrites the one from chosen ? > I just tested and U-Boot 'bootargs' has precedence over DT bootargs but I didn't find a way to append boot parameters from U-Boot. You can either overwrite it completely or not. That been said I think that is a good idea to have some default bootargs on the DT but since you can't append any boot option from U-Boot I would also add root=/dev/mmcblk0p2 rw rootwait so at least it will be able to mount the rootfs from the uSD/MMC. Also, many IGEP COM Module base boards also have serial consoles that are connected to the OMAP3 UART3 (ttyO2), so maybe is better to add this to omap3-igep.dtsi instead of omap3-igep0020.dts to avoid future duplication. Best regards, Javier
Hi Enric and Javier, >> The u-boot 'bootargs' env overwrites the one from chosen ? >> > > I just tested and U-Boot 'bootargs' has precedence over DT bootargs > but I didn't find a way to append boot parameters from U-Boot. You can > either overwrite it completely or not. > Yes. That seems to be the current case. Perhaps we can merge ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER and CMDLINE_EXTEND in one generic config stating the desired bootargs behavior. Does this sound sane? > That been said I think that is a good idea to have some default > bootargs on the DT but since you can't append any boot option from > U-Boot I would also add root=/dev/mmcblk0p2 rw rootwait so at least it > will be able to mount the rootfs from the uSD/MMC. > True. Will re-send with those. > Also, many IGEP COM Module base boards also have serial consoles that > are connected to the OMAP3 UART3 (ttyO2), so maybe is better to add > this to omap3-igep.dtsi instead of omap3-igep0020.dts to avoid future > duplication. > Ok. Thanks and merry xmas, Ezequiel
On Sat, Dec 22, 2012 at 3:17 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote: > Hi Enric and Javier, > >>> The u-boot 'bootargs' env overwrites the one from chosen ? >>> >> >> I just tested and U-Boot 'bootargs' has precedence over DT bootargs >> but I didn't find a way to append boot parameters from U-Boot. You can >> either overwrite it completely or not. >> > > Yes. That seems to be the current case. > Perhaps we can merge > ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER > and CMDLINE_EXTEND in one generic config stating > the desired bootargs behavior. > > Does this sound sane? > Hi Ezequiel, You could enable ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER on omap2plus_defconfig but just having a sane DTB bootargs default value is better IMHO. Best regards, Javier
On Sun, Dec 23, 2012 at 3:22 PM, Javier Martinez Canillas <martinez.javier@gmail.com> wrote: > On Sat, Dec 22, 2012 at 3:17 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote: >> Hi Enric and Javier, >> >>>> The u-boot 'bootargs' env overwrites the one from chosen ? >>>> >>> >>> I just tested and U-Boot 'bootargs' has precedence over DT bootargs >>> but I didn't find a way to append boot parameters from U-Boot. You can >>> either overwrite it completely or not. >>> >> >> Yes. That seems to be the current case. >> Perhaps we can merge >> ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER >> and CMDLINE_EXTEND in one generic config stating >> the desired bootargs behavior. >> >> Does this sound sane? >> > > Hi Ezequiel, > > You could enable ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER on > omap2plus_defconfig Actually, ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER depends on ARM_ATAG_DTB_COMPAT being selected and it's only compatibility stuff for bootloaders non DTB capable. I don't think we should add that to omap2plus_defconfig. > but just having a sane DTB bootargs default value > is better IMHO. > Agreed. I'll send a v2 with your proposed default command line.
diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index e2b9849..45ffe21 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -15,6 +15,10 @@ model = "IGEPv2"; compatible = "isee,omap3-igep0020", "ti,omap3"; + chosen { + bootargs = "console=ttyO2,115200n8 earlyprintk"; + }; + leds { compatible = "gpio-leds"; boot {
IGEP v2 boards has console as ttyO2,115200n8. It's better so simply set this as the default kernel argument directly in the device tree board file. Cc: Enric Balletbo i Serra <eballetbo@gmail.com> Cc: Javier Martinez Canillas <javier@dowhile0.org> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- arch/arm/boot/dts/omap3-igep0020.dts | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)