| Message ID | 1356959231-17335-8-git-send-email-vaibhav.bedia@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 31 December 2012 06:37 PM, Vaibhav Bedia wrote: > TPTC0 needs to be idled and put to standby under SW control. > Add the appropriate flags in the TPTC0 hwmod entry. > Can you please expand TPTC0 in chane log. > Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > Cc: Benoit Cousson <b-cousson@ti.com> > Cc: Paul Walmsley <paul@pwsan.com> > Cc: Kevin Hilman <khilman@deeprootsystems.com> > Cc: Vaibhav Hiremath <hvaibhav@ti.com> > --- Patch is fine otherwise. Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
On Tue, Jan 08, 2013 at 20:35:39, Shilimkar, Santosh wrote: > On Monday 31 December 2012 06:37 PM, Vaibhav Bedia wrote: > > TPTC0 needs to be idled and put to standby under SW control. > > Add the appropriate flags in the TPTC0 hwmod entry. > > > Can you please expand TPTC0 in chane log. Third Party Transfer Controller. It's part of the DMA IP. Will add it in the changelog. > > Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com> > > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Cc: Benoit Cousson <b-cousson@ti.com> > > Cc: Paul Walmsley <paul@pwsan.com> > > Cc: Kevin Hilman <khilman@deeprootsystems.com> > > Cc: Vaibhav Hiremath <hvaibhav@ti.com> > > --- > Patch is fine otherwise. > Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > >
Vaibhav Bedia <vaibhav.bedia@ti.com> writes: > TPTC0 needs to be idled and put to standby under SW control. Please elaborate about why (e.g. HW support not available, HW support broken/buggy, etc.) since these blocks are not well documented in the docs that I have (spruh73f.) Thanks, Kevin > Add the appropriate flags in the TPTC0 hwmod entry. > > Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > Cc: Benoit Cousson <b-cousson@ti.com> > Cc: Paul Walmsley <paul@pwsan.com> > Cc: Kevin Hilman <khilman@deeprootsystems.com> > Cc: Vaibhav Hiremath <hvaibhav@ti.com> > --- > v1->v2: > No change > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > index 5e50e68..5c34d4b 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > @@ -1823,6 +1823,7 @@ static struct omap_hwmod am33xx_tptc0_hwmod = { > .class = &am33xx_tptc_hwmod_class, > .clkdm_name = "l3_clkdm", > .mpu_irqs = am33xx_tptc0_irqs, > + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY), > .main_clk = "l3_gclk", > .prcm = { > .omap4 = {
Hi Kevin, On Tue, Feb 12, 2013 at 05:03:23, Kevin Hilman wrote: > Vaibhav Bedia <vaibhav.bedia@ti.com> writes: > > > TPTC0 needs to be idled and put to standby under SW control. > > Please elaborate about why (e.g. HW support not available, HW support > broken/buggy, etc.) since these blocks are not well documented in the > docs that I have (spruh73f.) > This change was picked up for v3.9. I'll submit a follow-up patch adding in a comment in the hwmod file for this. Regards, Vaibhav
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index 5e50e68..5c34d4b 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -1823,6 +1823,7 @@ static struct omap_hwmod am33xx_tptc0_hwmod = { .class = &am33xx_tptc_hwmod_class, .clkdm_name = "l3_clkdm", .mpu_irqs = am33xx_tptc0_irqs, + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY), .main_clk = "l3_gclk", .prcm = { .omap4 = {
TPTC0 needs to be idled and put to standby under SW control. Add the appropriate flags in the TPTC0 hwmod entry. Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> Cc: Benoit Cousson <b-cousson@ti.com> Cc: Paul Walmsley <paul@pwsan.com> Cc: Kevin Hilman <khilman@deeprootsystems.com> Cc: Vaibhav Hiremath <hvaibhav@ti.com> --- v1->v2: No change arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)