From patchwork Wed Jan 9 13:41:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 1952751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 4555EDF215 for ; Wed, 9 Jan 2013 13:45:53 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tsvv6-0008FE-DA; Wed, 09 Jan 2013 13:42:16 +0000 Received: from mail-pa0-f53.google.com ([209.85.220.53]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tsvuw-0008D4-Rb for linux-arm-kernel@lists.infradead.org; Wed, 09 Jan 2013 13:42:09 +0000 Received: by mail-pa0-f53.google.com with SMTP id hz1so1047934pad.12 for ; Wed, 09 Jan 2013 05:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=GMOKOcctsHVZSnftWtmsJUyTxx09Ys58o5HDZiJ7tWQ=; b=dC+j5pq7G65IaPWSJRS4U7GdqHwGysv4PONsM6QgzCkaFO1LfcAHDafQMHIzqdIdvQ hg4tgxM3WsUfSHZqEuAptiWS2zWuCK4ALLV2GdwqmZvq2hgWFENnKCnB/kVekEqnRoD8 kIP3OK0ixZUyhuNRVq631npjfuwVugMhcfsJrXekYUB/GGZmE9yfn3d1LlROF2r9adjT 3rVWjg/JVEQXpCfKI9DH0fcHNTbvNf0NOm0EgfbuwT3DptdUtErjaTOsxbKXjZfOCjjw MWSXZcQW7/zsDLPgrgvO0ve2dSQ6ZObSSa7TZJP1jNT5DfcaCeaMHFm5Ba0bGGtxPmOo qnrA== X-Received: by 10.68.209.170 with SMTP id mn10mr211111626pbc.11.1357738925134; Wed, 09 Jan 2013 05:42:05 -0800 (PST) Received: from localhost.localdomain ([122.166.13.141]) by mx.google.com with ESMTPS id k4sm42842184paz.26.2013.01.09.05.41.59 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Jan 2013 05:42:04 -0800 (PST) From: "Lad, Prabhakar" To: LMML Subject: [PATCH RFC 2/3] tvp514x: support asynchronous probing Date: Wed, 9 Jan 2013 19:11:26 +0530 Message-Id: <1357738887-8701-3-git-send-email-prabhakar.lad@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1357738887-8701-1-git-send-email-prabhakar.lad@ti.com> References: <1357738887-8701-1-git-send-email-prabhakar.lad@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130109_084207_116845_DB57D6E4 X-CRM114-Status: GOOD ( 15.88 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.53 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (prabhakar.csengg[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: DLOS , Mauro Carvalho Chehab , Sekhar Nori , LKML , Mauro Carvalho Chehab , Hans Verkuil , Hans Verkuil , Laurent Pinchart , Sakari Ailus , "Lad, Prabhakar" , Guennadi Liakhovetski , LAK X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Both synchronous and asynchronous tvp514x subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/media/i2c/tvp514x.c | 20 ++++++++++++++------ 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c index aa94ebc..a4f0a70 100644 --- a/drivers/media/i2c/tvp514x.c +++ b/drivers/media/i2c/tvp514x.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include @@ -102,6 +103,7 @@ struct tvp514x_decoder { struct v4l2_ctrl_handler hdl; struct tvp514x_reg tvp514x_regs[ARRAY_SIZE(tvp514x_reg_list_default)]; const struct tvp514x_platform_data *pdata; + struct v4l2_async_subdev_list asdl; int ver; int streaming; @@ -941,22 +943,22 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct tvp514x_decoder *decoder; struct v4l2_subdev *sd; + int ret; /* Check if the adapter supports the needed features */ if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) return -EIO; - if (!client->dev.platform_data) { - v4l2_err(client, "No platform data!!\n"); - return -ENODEV; - } - decoder = devm_kzalloc(&client->dev, sizeof(*decoder), GFP_KERNEL); if (!decoder) return -ENOMEM; /* Initialize the tvp514x_decoder with default configuration */ *decoder = tvp514x_dev; + if (!client->dev.platform_data) { + v4l2_err(client, "No platform data!!\n"); + return -EPROBE_DEFER; + } /* Copy default register configuration */ memcpy(decoder->tvp514x_regs, tvp514x_reg_list_default, sizeof(tvp514x_reg_list_default)); @@ -980,6 +982,11 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) /* Register with V4L2 layer as slave device */ sd = &decoder->sd; + decoder->asdl.subdev = &decoder->sd; + decoder->asdl.dev = &client->dev; + ret = v4l2_async_subdev_bind(&decoder->asdl); + if (ret < 0) + return ret; v4l2_i2c_subdev_init(sd, client, &tvp514x_ops); v4l2_ctrl_handler_init(&decoder->hdl, 5); @@ -1004,7 +1011,7 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) v4l2_info(sd, "%s decoder driver registered !!\n", sd->name); - return 0; + return v4l2_async_subdev_bound(&decoder->asdl); } @@ -1020,6 +1027,7 @@ static int tvp514x_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); struct tvp514x_decoder *decoder = to_decoder(sd); + v4l2_async_subdev_unbind(&decoder->asdl); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&decoder->hdl); return 0;