| Message ID | 1358491295-4022-3-git-send-email-avinashphilip@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2013-01-18 at 12:11 +0530, Philip Avinash wrote: > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index eaef5e7..f4209d8 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -393,5 +393,17 @@ > ti,hwmods = "elm"; > status = "disabled"; > }; > + > + gpmc: gpmc@50000000 { > + compatible = "ti,am3352-gpmc"; > + ti,hwmods = "gpmc"; > + reg = <0x50000000 0x2000>; > + interrupts = <100>; > + num-cs = <8>; According to the AM335x TRM (SPRUH73G) page 254 we have GPMC_CSn[6:0], so num-cs should probably be <7>. > + num-waitpins = <2>; > + #address-cells = <2>; > + #size-cells = <1>; > + status = "disabled"; > + }; > }; > };
>>>>> "Philip" == Philip Avinash <avinashphilip@ti.com> writes: Philip> From: "Philip, Avinash" <avinashphilip@ti.com> Philip> Add GPMC data node to AM33XX device tree file. Philip> Signed-off-by: Philip Avinash <avinashphilip@ti.com> Philip> --- Philip> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ Philip> 1 file changed, 12 insertions(+) Philip> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi Philip> index eaef5e7..f4209d8 100644 Philip> --- a/arch/arm/boot/dts/am33xx.dtsi Philip> +++ b/arch/arm/boot/dts/am33xx.dtsi Philip> @@ -393,5 +393,17 @@ Philip> ti,hwmods = "elm"; Philip> status = "disabled"; Philip> }; Philip> + Philip> + gpmc: gpmc@50000000 { Philip> + compatible = "ti,am3352-gpmc"; Philip> + ti,hwmods = "gpmc"; Philip> + reg = <0x50000000 0x2000>; Philip> + interrupts = <100>; Philip> + num-cs = <8>; Next to Jan's comment about am335x having 7 cs signals, I just realized the difference in compatible string between the gpmc and elm. The gpmc refers to a real device (which is afaik how it should be done), but the elm compatible is simply ti,am33xx-elm. Presumably it should have been ti,am3352-elm in the binding instead? Other than that it looks fine. Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
On Tue, Jan 22, 2013 at 02:31:53, Peter Korsgaard wrote: > >>>>> "Philip" == Philip Avinash <avinashphilip@ti.com> writes: > > Philip> From: "Philip, Avinash" <avinashphilip@ti.com> > Philip> Add GPMC data node to AM33XX device tree file. > > Philip> Signed-off-by: Philip Avinash <avinashphilip@ti.com> > Philip> --- > Philip> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ > Philip> 1 file changed, 12 insertions(+) > > Philip> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > Philip> index eaef5e7..f4209d8 100644 > Philip> --- a/arch/arm/boot/dts/am33xx.dtsi > Philip> +++ b/arch/arm/boot/dts/am33xx.dtsi > Philip> @@ -393,5 +393,17 @@ > Philip> ti,hwmods = "elm"; > Philip> status = "disabled"; > Philip> }; > Philip> + > Philip> + gpmc: gpmc@50000000 { > Philip> + compatible = "ti,am3352-gpmc"; > Philip> + ti,hwmods = "gpmc"; > Philip> + reg = <0x50000000 0x2000>; > Philip> + interrupts = <100>; > Philip> + num-cs = <8>; > > Next to Jan's comment about am335x having 7 cs signals, I just realized > the difference in compatible string between the gpmc and elm. The gpmc > refers to a real device (which is afaik how it should be done), but the > elm compatible is simply ti,am33xx-elm. > > Presumably it should have been ti,am3352-elm in the binding instead? I thought of following the file name convention. I will correct to "ti,am3352-elm" > > Other than that it looks fine. > > Acked-by: Peter Korsgaard <jacmet@sunsite.dk> Thanks Avinash > > -- > Bye, Peter Korsgaard >
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index eaef5e7..f4209d8 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -393,5 +393,17 @@ ti,hwmods = "elm"; status = "disabled"; }; + + gpmc: gpmc@50000000 { + compatible = "ti,am3352-gpmc"; + ti,hwmods = "gpmc"; + reg = <0x50000000 0x2000>; + interrupts = <100>; + num-cs = <8>; + num-waitpins = <2>; + #address-cells = <2>; + #size-cells = <1>; + status = "disabled"; + }; }; };