| Message ID | 1358922764-31654-2-git-send-email-Ying.Liu@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 23, 2013 at 02:32:44PM +0800, Liu Ying wrote: > This patch adds at24c512b i2c device to the device tree > along with the necessary i2c device node and pinctrl > settings for i2c bus. > The eeprom chip is populated on the accessory board of > the imx51-babbage board. Given that it's optional should the binding be here anyway? I don't have this accessory board and this may conflict with the boards other people have connected on this port. Sascha > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > arch/arm/boot/dts/imx51-babbage.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx51.dtsi | 9 +++++++++ > 2 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts > index 567e7ee..4f0fc75 100644 > --- a/arch/arm/boot/dts/imx51-babbage.dts > +++ b/arch/arm/boot/dts/imx51-babbage.dts > @@ -241,6 +241,18 @@ > }; > }; > > + i2c@83fc8000 { /* I2C1 */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1_1>; > + status = "okay"; > + > + at24@50 { > + compatible = "at24,24c512b"; > + pagesize = <128>; > + reg = <0x50>; > + }; > + }; > + > audmux@83fd0000 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_audmux_1>; > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi > index 1f5d45e..6495c69 100644 > --- a/arch/arm/boot/dts/imx51.dtsi > +++ b/arch/arm/boot/dts/imx51.dtsi > @@ -311,6 +311,15 @@ > }; > }; > > + i2c1 { > + pinctrl_i2c1_1: i2c1grp-1 { > + fsl,pins = < > + 4 0x400001ed /* MX51_PAD_EIM_D16__I2C1_SDA */ > + 23 0x400001ed /* MX51_PAD_EIM_D19__I2C1_SCL */ > + >; > + }; > + }; > + > i2c2 { > pinctrl_i2c2_1: i2c2grp-1 { > fsl,pins = < > -- > 1.7.1 > > >
2013/1/23 Sascha Hauer <s.hauer@pengutronix.de>: > On Wed, Jan 23, 2013 at 02:32:44PM +0800, Liu Ying wrote: >> This patch adds at24c512b i2c device to the device tree >> along with the necessary i2c device node and pinctrl >> settings for i2c bus. >> The eeprom chip is populated on the accessory board of >> the imx51-babbage board. > > Given that it's optional should the binding be here anyway? I don't have > this accessory board and this may conflict with the boards other people > have connected on this port. > > Sascha Understand your concern. Is there any way to handle this? How can we support the present accessory board correctly? More generally, not all main boards can figure out what kind of accessory board is attached to them, at least, some main boards can only figure out limited number of accessory boards by using some ways of board ID check. > >> >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> --- >> arch/arm/boot/dts/imx51-babbage.dts | 12 ++++++++++++ >> arch/arm/boot/dts/imx51.dtsi | 9 +++++++++ >> 2 files changed, 21 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts >> index 567e7ee..4f0fc75 100644 >> --- a/arch/arm/boot/dts/imx51-babbage.dts >> +++ b/arch/arm/boot/dts/imx51-babbage.dts >> @@ -241,6 +241,18 @@ >> }; >> }; >> >> + i2c@83fc8000 { /* I2C1 */ >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c1_1>; >> + status = "okay"; >> + >> + at24@50 { >> + compatible = "at24,24c512b"; >> + pagesize = <128>; >> + reg = <0x50>; >> + }; >> + }; >> + >> audmux@83fd0000 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_audmux_1>; >> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi >> index 1f5d45e..6495c69 100644 >> --- a/arch/arm/boot/dts/imx51.dtsi >> +++ b/arch/arm/boot/dts/imx51.dtsi >> @@ -311,6 +311,15 @@ >> }; >> }; >> >> + i2c1 { >> + pinctrl_i2c1_1: i2c1grp-1 { >> + fsl,pins = < >> + 4 0x400001ed /* MX51_PAD_EIM_D16__I2C1_SDA */ >> + 23 0x400001ed /* MX51_PAD_EIM_D19__I2C1_SCL */ >> + >; >> + }; >> + }; >> + >> i2c2 { >> pinctrl_i2c2_1: i2c2grp-1 { >> fsl,pins = < >> -- >> 1.7.1 >> >> >> > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On Wed, Jan 23, 2013 at 03:51:12PM +0800, Liu Ying wrote: > 2013/1/23 Sascha Hauer <s.hauer@pengutronix.de>: > > On Wed, Jan 23, 2013 at 02:32:44PM +0800, Liu Ying wrote: > >> This patch adds at24c512b i2c device to the device tree > >> along with the necessary i2c device node and pinctrl > >> settings for i2c bus. > >> The eeprom chip is populated on the accessory board of > >> the imx51-babbage board. > > > > Given that it's optional should the binding be here anyway? I don't have > > this accessory board and this may conflict with the boards other people > > have connected on this port. > > > > Sascha > > Understand your concern. Is there any way to handle this? How can we support > the present accessory board correctly? More generally, not all main boards can > figure out what kind of accessory board is attached to them, at least, some main > boards can only figure out limited number of accessory boards by using some ways > of board ID check. We don't have support for such things atm. We'll have to wait for OF: Introduce DT overlay support. Pantelis Antoniou is working on this currently. Sascha
2013/1/23 Sascha Hauer <s.hauer@pengutronix.de>: > On Wed, Jan 23, 2013 at 03:51:12PM +0800, Liu Ying wrote: >> 2013/1/23 Sascha Hauer <s.hauer@pengutronix.de>: >> > On Wed, Jan 23, 2013 at 02:32:44PM +0800, Liu Ying wrote: >> >> This patch adds at24c512b i2c device to the device tree >> >> along with the necessary i2c device node and pinctrl >> >> settings for i2c bus. >> >> The eeprom chip is populated on the accessory board of >> >> the imx51-babbage board. >> > >> > Given that it's optional should the binding be here anyway? I don't have >> > this accessory board and this may conflict with the boards other people >> > have connected on this port. >> > >> > Sascha >> >> Understand your concern. Is there any way to handle this? How can we support >> the present accessory board correctly? More generally, not all main boards can >> figure out what kind of accessory board is attached to them, at least, some main >> boards can only figure out limited number of accessory boards by using some ways >> of board ID check. > > We don't have support for such things atm. We'll have to wait for > > OF: Introduce DT overlay support. > > Pantelis Antoniou is working on this currently. > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | Good to know that. Thanks.
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts index 567e7ee..4f0fc75 100644 --- a/arch/arm/boot/dts/imx51-babbage.dts +++ b/arch/arm/boot/dts/imx51-babbage.dts @@ -241,6 +241,18 @@ }; }; + i2c@83fc8000 { /* I2C1 */ + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1_1>; + status = "okay"; + + at24@50 { + compatible = "at24,24c512b"; + pagesize = <128>; + reg = <0x50>; + }; + }; + audmux@83fd0000 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_audmux_1>; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index 1f5d45e..6495c69 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -311,6 +311,15 @@ }; }; + i2c1 { + pinctrl_i2c1_1: i2c1grp-1 { + fsl,pins = < + 4 0x400001ed /* MX51_PAD_EIM_D16__I2C1_SDA */ + 23 0x400001ed /* MX51_PAD_EIM_D19__I2C1_SCL */ + >; + }; + }; + i2c2 { pinctrl_i2c2_1: i2c2grp-1 { fsl,pins = <
This patch adds at24c512b i2c device to the device tree along with the necessary i2c device node and pinctrl settings for i2c bus. The eeprom chip is populated on the accessory board of the imx51-babbage board. Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- arch/arm/boot/dts/imx51-babbage.dts | 12 ++++++++++++ arch/arm/boot/dts/imx51.dtsi | 9 +++++++++ 2 files changed, 21 insertions(+), 0 deletions(-)