diff mbox

[RESEND] ARM: dts: max77686: Add DTS file for max77686 PMIC

Message ID 1359053177-17725-1-git-send-email-tobetter@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dongjin Kim Jan. 24, 2013, 6:46 p.m. UTC 
This patch adds a dedicated DTS file for max77686 PMIC, supposed to be included
in a board DTS to control the power for certain consumer devices or AP with 9 BUCKs
and 26 LDOs

Signed-off-by: Dongjin Kim <tobetter@gmail.com>
---
 arch/arm/boot/dts/max77686.dtsi |  156 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 156 insertions(+)
 create mode 100644 arch/arm/boot/dts/max77686.dtsi

Comments

Mark Brown Jan. 26, 2013, 5:06 a.m. UTC | #1 
On Fri, Jan 25, 2013 at 03:46:08AM +0900, Dongjin Kim wrote:

> ---
>  arch/arm/boot/dts/max77686.dtsi |  156 +++++++++++++++++++++++++++++++++++++++

Why is this in arch/arm?  This isn't an ARM-specific chip.
Dongjin Kim Jan. 26, 2013, 6:06 a.m. UTC | #2 
Hello Mark,

Yes, this is not ARM-specific chip at all. Just wanted to be reviewed
by you and others if the format is ok before integrating to my board
file. I had sent similar one before,
https://patchwork.kernel.org/patch/1287711, and you advised that was
too board specific. And plan to integrate like OMAP boards have with
twl6030.dtsi and twl6040.dtsi.

If would be nice if somewhere you specify a directory for such device files.

Regards,
Dongjin.

On Sat, Jan 26, 2013 at 2:06 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Jan 25, 2013 at 03:46:08AM +0900, Dongjin Kim wrote:
>
>> ---
>>  arch/arm/boot/dts/max77686.dtsi |  156 +++++++++++++++++++++++++++++++++++++++
>
> Why is this in arch/arm?  This isn't an ARM-specific chip.
Mark Brown Jan. 27, 2013, 6:17 a.m. UTC | #3 
On Sat, Jan 26, 2013 at 03:06:53PM +0900, Dongjin Kim wrote:
> Hello Mark,
> 
> Yes, this is not ARM-specific chip at all. Just wanted to be reviewed
> by you and others if the format is ok before integrating to my board
> file. I had sent similar one before,
> https://patchwork.kernel.org/patch/1287711, and you advised that was
> too board specific. And plan to integrate like OMAP boards have with
> twl6030.dtsi and twl6040.dtsi.

> If would be nice if somewhere you specify a directory for such device files.

I think we need to create one, not quite sure where though.  drivers/of
perhaps but that's a bit non-idiomatic, or possibly something top level.
firmware might do too.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/max77686.dtsi b/arch/arm/boot/dts/max77686.dtsi
new file mode 100644
index 0000000..b80baef
--- /dev/null
+++ b/arch/arm/boot/dts/max77686.dtsi
@@ -0,0 +1,156 @@ 
+/*
+ * Copyright (C) 2013 Dongjin Kim <tobetter@gmail.com>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ */
+
+&max77686 {
+	compatible = "maxim,max77686";
+
+	interrupt-controller;
+	#interrupt-cells = <1>;
+
+	voltage-regulators {
+		buck1: buck@10 {
+			regulator-compatible = "BUCK1";
+		};
+
+		buck2: buck@12 {
+			regulator-compatible = "BUCK2";
+		};
+
+		buck3: buck@1c {
+			regulator-compatible = "BUCK3";
+		};
+
+		buck4: buck@26 {
+			regulator-compatible = "BUCK4";
+		};
+
+		buck5: buck@30 {
+			regulator-compatible = "BUCK5";
+		};
+
+		buck6: buck@32 {
+			regulator-compatible = "BUCK6";
+		};
+
+		buck7: buck@34 {
+			regulator-compatible = "BUCK7";
+		};
+
+		buck8: buck@36 {
+			regulator-compatible = "BUCK8";
+		};
+
+		buck9: buck@38 {
+			regulator-compatible = "BUCK9";
+		};
+
+		ldo1: ldo@40 {
+			regulator-compatible = "LDO1";
+		};
+
+		ldo2: ldo@41 {
+			regulator-compatible = "LDO2";
+		};
+
+		ldo3: ldo@42 {
+			regulator-compatible = "LDO3";
+		};
+
+		ldo4: ldo@43 {
+			regulator-compatible = "LDO4";
+		};
+
+		ldo5: ldo@44 {
+			regulator-compatible = "LDO5";
+		};
+
+		ldo6: ldo@45 {
+			regulator-compatible = "LDO6";
+		};
+
+		ldo7: ldo@46 {
+			regulator-compatible = "LDO7";
+		};
+
+		ldo8: ldo@47 {
+			regulator-compatible = "LDO8";
+		};
+
+		ldo9: ldo@48 {
+			regulator-compatible = "LDO9";
+		};
+
+		ldo10: ldo@49 {
+			regulator-compatible = "LDO10";
+		};
+
+		ldo11: ldo@4a {
+			regulator-compatible = "LDO11";
+		};
+
+		ldo12: ldo@4b {
+			regulator-compatible = "LDO12";
+		};
+
+		ldo13: ldo@4c {
+			regulator-compatible = "LDO13";
+		};
+
+		ldo14: ldo@4d {
+			regulator-compatible = "LDO14";
+		};
+
+		ldo15: ldo@4e {
+			regulator-compatible = "LDO15";
+		};
+
+		ldo16: ldo@4f {
+			regulator-compatible = "LDO16";
+		};
+
+		ldo17: ldo@50 {
+			regulator-compatible = "LDO17";
+		};
+
+		ldo18: ldo@51 {
+			regulator-compatible = "LDO18";
+		};
+
+		ldo19: ldo@52 {
+			regulator-compatible = "LDO19";
+		};
+
+		ldo20: ldo@53 {
+			regulator-compatible = "LDO20";
+		};
+
+		ldo21: ldo@54 {
+			regulator-compatible = "LDO21";
+		};
+
+		ldo22: ldo@55 {
+			regulator-compatible = "LDO22";
+		};
+
+		ldo23: ldo@56 {
+			regulator-compatible = "LDO23";
+		};
+
+		ldo24: ldo@57 {
+			regulator-compatible = "LDO24";
+		};
+
+		ldo25: ldo@58 {
+			regulator-compatible = "LDO25";
+		};
+
+		ldo26: ldo@59 {
+			regulator-compatible = "LDO26";
+		};
+	};
+};