| Message ID | 1359376250-18841-1-git-send-email-michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/28/2013 06:30 AM, Michal Simek wrote: > The patch: "ARM: use common irqchip_init for GIC init" > (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) > should also add linux/irqchip.h header. > > Error message: > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' > undeclared here (not in a function) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> FYI, there's already a patch posted for this: http://www.spinics.net/lists/arm-kernel/msg219556.html Rob > --- > arch/arm/mach-zynq/common.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c > index 6472a69..cf3ec54 100644 > --- a/arch/arm/mach-zynq/common.c > +++ b/arch/arm/mach-zynq/common.c > @@ -24,6 +24,7 @@ > #include <linux/of_irq.h> > #include <linux/of_platform.h> > #include <linux/of.h> > +#include <linux/irqchip.h> > > #include <asm/mach/arch.h> > #include <asm/mach/map.h> >
Hi Rob, 2013/1/28 Rob Herring <robherring2@gmail.com>: > On 01/28/2013 06:30 AM, Michal Simek wrote: >> The patch: "ARM: use common irqchip_init for GIC init" >> (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) >> should also add linux/irqchip.h header. >> >> Error message: >> arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' >> undeclared here (not in a function) >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > FYI, there's already a patch posted for this: > > http://www.spinics.net/lists/arm-kernel/msg219556.html Interesting that I am completely ignored in CC. Anyway updated maintainer fragment hopefully resolve this. Thanks, Michal
On Mon, Jan 28, 2013 at 01:30:50PM +0100, Michal Simek wrote: > The patch: "ARM: use common irqchip_init for GIC init" > (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) > should also add linux/irqchip.h header. > > Error message: > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' > undeclared here (not in a function) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Applied. -Olof
diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index 6472a69..cf3ec54 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -24,6 +24,7 @@ #include <linux/of_irq.h> #include <linux/of_platform.h> #include <linux/of.h> +#include <linux/irqchip.h> #include <asm/mach/arch.h> #include <asm/mach/map.h>
The patch: "ARM: use common irqchip_init for GIC init" (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) should also add linux/irqchip.h header. Error message: arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/arm/mach-zynq/common.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)