From patchwork Wed Jan 30 01:55:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Cross X-Patchwork-Id: 2064941 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 9F0BCDF23E for ; Wed, 30 Jan 2013 01:59:32 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U0MuH-0005ph-Sm; Wed, 30 Jan 2013 01:56:09 +0000 Received: from mail-yh0-f74.google.com ([209.85.213.74]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U0MuD-0005oU-MG for linux-arm-kernel@lists.infradead.org; Wed, 30 Jan 2013 01:56:07 +0000 Received: by mail-yh0-f74.google.com with SMTP id z6so110048yhz.3 for ; Tue, 29 Jan 2013 17:56:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=l8buiuIis/7B1jOmNItrk3B+/7J0NzooKEp81IBxDTA=; b=iITtDba9Pn7roxQinIHvUtFlbvUk3gIqj2h3p5F5N9VQXVXxQUsVjnSzwxtWL6igux 1ZMYlzm/QfXCwbQhe45Dx+pPx+rJeWVN6Je3tp5a+XBH39+kJgvhtfN+WmtyFF8m7yWC ujeJcLJDiAi5+xV9WD6KSWumgstJ9JGDklgzy0WtEr1Ur5VZY/t9nPVehmqjcd5yYnog y0f/roTpEAh+RpyWOdbASwacrhnSRwePJVqasppUh3TL2+MTcH4TSnm77eWPHRKDsDSb Bpc/5PSK9PdzC1/L4qRNKZg8UE4cjJQdxNRlCBGzpc/+j1DSmUxhrQLNhIByOcMPd6Nb lmBg== X-Received: by 10.236.85.211 with SMTP id u59mr1358417yhe.38.1359510964134; Tue, 29 Jan 2013 17:56:04 -0800 (PST) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id e7si664761yhk.3.2013.01.29.17.56.04 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Tue, 29 Jan 2013 17:56:04 -0800 (PST) Received: from walnut.mtv.corp.google.com (walnut.mtv.corp.google.com [172.18.105.48]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id F1C8031C232; Tue, 29 Jan 2013 17:56:03 -0800 (PST) Received: by walnut.mtv.corp.google.com (Postfix, from userid 99897) id 9CBE51607DC; Tue, 29 Jan 2013 17:56:03 -0800 (PST) From: Colin Cross To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 3/3] ARM: stacktrace: enable save_stack_trace_tsk for CONFIG_SMP Date: Tue, 29 Jan 2013 17:55:47 -0800 Message-Id: <1359510947-3950-4-git-send-email-ccross@android.com> X-Mailer: git-send-email 1.8.1 In-Reply-To: <1359510947-3950-1-git-send-email-ccross@android.com> References: <1359510947-3950-1-git-send-email-ccross@android.com> X-Gm-Message-State: ALoCoQkh7vvZCCyp70yWqgZvJgT3dC02fowTCqfWwNczjBEQrVSdB8pihN9AMOAvAE6tGfx9rnCw3yJ0iVpRlhVk8FWanlrdFO5xtXNCGYTiAebLKeWtBIJW5gAjMYSmRG9RqtHhfuo/Yj7sb/Mcf/s0w02aaYVfV5CcbfHRpIel11hLKXNeYnz6zivBow0CYI2E7hbwGQaeChflZax0u8DKw/vRynlSpw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130129_205605_796082_8C6369CB X-CRM114-Status: GOOD ( 10.78 ) X-Spam-Score: -3.3 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.74 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Dave Martin , Laura Abbott , Catalin Marinas , Will Deacon , Rabin Vincent , Colin Cross , Russell King X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Now that unwind_frame has been hardened against invalid stacks for CONFIG_ARM_UNWIND or CONFIG_FRAME_POINTER, enable dumping the stack on non-current threads for CONFIG_SMP. Signed-off-by: Colin Cross --- arch/arm/kernel/stacktrace.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c index d897f4c..c6e6477 100644 --- a/arch/arm/kernel/stacktrace.c +++ b/arch/arm/kernel/stacktrace.c @@ -187,22 +187,11 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) data.skip = trace->skip; if (tsk != current) { -#ifdef CONFIG_SMP - /* - * What guarantees do we have here that 'tsk' is not - * running on another CPU? For now, ignore it as we - * can't guarantee we won't explode. - */ - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; - return; -#else data.no_sched_functions = 1; frame.fp = thread_saved_fp(tsk); frame.sp = thread_saved_sp(tsk); frame.lr = 0; /* recovered from the stack */ frame.pc = thread_saved_pc(tsk); -#endif } else { register unsigned long current_sp asm ("sp");