diff mbox

ARM: ux500: correct typo in pinctrl Device Tree node

Message ID 1359563102-5934-1-git-send-email-linus.walleij@stericsson.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Jan. 30, 2013, 4:25 p.m. UTC 
From: Lee Jones <lee.jones@linaro.org>

The preference is to use '-' instead of '_' in compatible strings.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/boot/dts/dbx5x0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Warren Jan. 30, 2013, 4:46 p.m. UTC | #1 
On 01/30/2013 09:25 AM, Linus Walleij wrote:
> The preference is to use '-' instead of '_' in compatible strings.

> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi

>  		pinctrl {
> -			compatible = "stericsson,nmk_pinctrl";
> +			compatible = "stericsson,nmk-pinctrl";

Is there a driver-side patch which this depends on too?
Lee Jones Jan. 30, 2013, 4:58 p.m. UTC | #2 
On Wed, 30 Jan 2013, Stephen Warren wrote:

> On 01/30/2013 09:25 AM, Linus Walleij wrote:
> > The preference is to use '-' instead of '_' in compatible strings.
> 
> > diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> 
> >  		pinctrl {
> > -			compatible = "stericsson,nmk_pinctrl";
> > +			compatible = "stericsson,nmk-pinctrl";
> 
> Is there a driver-side patch which this depends on too?

This seems very strange.

I'm going to reply to this email again with how the patch should look.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index 96f518b..69140ba 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -171,7 +171,7 @@ 
 		};
 
 		pinctrl {
-			compatible = "stericsson,nmk_pinctrl";
+			compatible = "stericsson,nmk-pinctrl";
 			prcm = <&prcmu>;
 		};