From patchwork Wed Feb 6 11:47:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haojian Zhuang X-Patchwork-Id: 2103851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 7CB0DDF2A1 for ; Wed, 6 Feb 2013 11:52:12 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U33UY-00014u-HP; Wed, 06 Feb 2013 11:48:42 +0000 Received: from mail-pa0-f53.google.com ([209.85.220.53]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U33UR-00014H-W8 for linux-arm-kernel@lists.infradead.org; Wed, 06 Feb 2013 11:48:37 +0000 Received: by mail-pa0-f53.google.com with SMTP id bg4so757061pad.40 for ; Wed, 06 Feb 2013 03:48:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=005S4hH5A3M0CVdCnuBAYpMMngGIN2vmV5e+MBqx9jA=; b=og6O7nmygguTETYOSN8wLnGxeE7sfdCMJ0CojCsV7pgWfuBv3ZBkPIOnMGtSv+vkhU Mq2fJPij5lIH8xJRfDzuPpUHgHZiwynZj1Ob6s4Jyohb9Krkl84xaY1KD24sgXzGkHxt f7LWLpvUqt6wLwqH0Qo1AmdOpgQ90fGP79UPGc3ZVeQ2/HpPZAm+o4r588JUqQrbiqT2 toh1unkvUU0ESz7x+EW3xyNAjkSGH/PwMLPZFxJN9UFzZk02qr87N3z9ipVW0mtA1qbb NdfcwICuD6ToBcAOwMVuUTll8on9704qXx+UXLoJWD3YIW+Qs1AHl7z+U8AVLKA0oyR7 NKEw== X-Received: by 10.66.80.70 with SMTP id p6mr75092992pax.23.1360151314571; Wed, 06 Feb 2013 03:48:34 -0800 (PST) Received: from localhost.localdomain ([67.198.145.34]) by mx.google.com with ESMTPS id f9sm37145024paz.12.2013.02.06.03.48.29 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Feb 2013 03:48:33 -0800 (PST) From: Haojian Zhuang To: jslaby@suse.cz, linus.walleij@linaro.org, anton.vorontsov@linaro.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] tty: serial: use module_init on pl011_init Date: Wed, 6 Feb 2013 19:47:15 +0800 Message-Id: <1360151235-11980-2-git-send-email-haojian.zhuang@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360151235-11980-1-git-send-email-haojian.zhuang@linaro.org> References: <1360151235-11980-1-git-send-email-haojian.zhuang@linaro.org> X-Gm-Message-State: ALoCoQmFlAKFsWtmgo7lAhopOnQ73o+Lb5A0j9NsOQLz5lW2JCyTDeSTq6t30MYXsQX6ZkdZd4nu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130206_064836_142560_CF841B03 X-CRM114-Status: GOOD ( 10.29 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.53 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Greg Kroah-Hartman , Alan Cox , Haojian Zhuang , linux-serial@vger.kernel.org, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If amba serial driver is probed defer, amba serial driver may be probed after init process. So the error log shows in below. [ 0.389403] Warning: unable to open an initial console. [ 0.390107] Freeing init memory: 2328K It results in serial console not enabled. So replace arch_initcall by module_init on pl011_init(). The boot sequence is changed in below. pinctrl driver --> amba serial driver --> init process Signed-off-by: Haojian Zhuang Cc: Alan Cox Cc: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org --- drivers/tty/serial/amba-pl011.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index d43d530..8b7dacb 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2129,11 +2129,7 @@ static void __exit pl011_exit(void) uart_unregister_driver(&amba_reg); } -/* - * While this can be a module, if builtin it's most likely the console - * So let's leave module_exit but move module_init to an earlier place - */ -arch_initcall(pl011_init); +module_init(pl011_init); module_exit(pl011_exit); MODULE_AUTHOR("ARM Ltd/Deep Blue Solutions Ltd");