| Message ID | 1360337803-19858-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 08, 2013 at 01:36:41PM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that > touchscreen can be functional. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Queued all 3 for 3.10. Shawn > --- > arch/arm/boot/dts/imx28-evk.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts > index 2da316e..5960578 100644 > --- a/arch/arm/boot/dts/imx28-evk.dts > +++ b/arch/arm/boot/dts/imx28-evk.dts > @@ -155,6 +155,7 @@ > }; > > lradc@80050000 { > + fsl,lradc-touchscreen-wires = <4>; > status = "okay"; > }; > > -- > 1.7.9.5 >
Dear Shawn Guo, > On Fri, Feb 08, 2013 at 01:36:41PM -0200, Fabio Estevam wrote: > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that > > touchscreen can be functional. > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Queued all 3 for 3.10. I dont intend to ramble or annoy you (I already did that plenty ;-) ), but can we not speed this up and push these simple stuffs for 3.9? Best regards, Marek Vasut
On Sun, Feb 17, 2013 at 11:31:24AM +0100, Marek Vasut wrote: > Dear Shawn Guo, > > > On Fri, Feb 08, 2013 at 01:36:41PM -0200, Fabio Estevam wrote: > > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > > > Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that > > > touchscreen can be functional. > > > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > > Queued all 3 for 3.10. > > I dont intend to ramble or annoy you (I already did that plenty ;-) ), but can > we not speed this up and push these simple stuffs for 3.9? No. arm-soc folks require that material for each merge window should be reaching them around -rc6 time (2 weeks to opening of the merge window). So it's simply late for 3.9. Shawn
Dear Shawn Guo, > On Sun, Feb 17, 2013 at 11:31:24AM +0100, Marek Vasut wrote: > > Dear Shawn Guo, > > > > > On Fri, Feb 08, 2013 at 01:36:41PM -0200, Fabio Estevam wrote: > > > > From: Fabio Estevam <fabio.estevam@freescale.com> > > > > > > > > Provide 'lradc-touchscreen-wires' property to the LRADC driver, so > > > > that touchscreen can be functional. > > > > > > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > > > > Queued all 3 for 3.10. > > > > I dont intend to ramble or annoy you (I already did that plenty ;-) ), > > but can we not speed this up and push these simple stuffs for 3.9? > > No. arm-soc folks require that material for each merge window should be > reaching them around -rc6 time (2 weeks to opening of the merge window). > So it's simply late for 3.9. Ah I see, thanks for clearing this up. Best regards, Marek Vasut
On Fri, Feb 08, 2013 at 01:36:41PM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Provide 'lradc-touchscreen-wires' property to the LRADC driver, so that > touchscreen can be functional. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > arch/arm/boot/dts/imx28-evk.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts > index 2da316e..5960578 100644 > --- a/arch/arm/boot/dts/imx28-evk.dts > +++ b/arch/arm/boot/dts/imx28-evk.dts > @@ -155,6 +155,7 @@ > }; > > lradc@80050000 { > + fsl,lradc-touchscreen-wires = <4>; I do not understand why. But it seems to me that applying the patch on top of v3.9-rc1 results in a silent audio playback on my imx28-evk board. Can you confirm that on your side? Shawn > status = "okay"; > }; > > -- > 1.7.9.5 >
On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > I do not understand why. But it seems to me that applying the patch on > top of v3.9-rc1 results in a silent audio playback on my imx28-evk > board. Can you confirm that on your side? Just tested and I confirm I see the same issue here on 3.9-rc1. However, when applying the touchscreen support on top of 3.8 (from this tree https://github.com/Freescale/linux-mainline/commits/patches-3.8 ) both touch and audio work as expected.
On Tue, Mar 05, 2013 at 11:07:55AM -0300, Fabio Estevam wrote: > On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > I do not understand why. But it seems to me that applying the patch on > > top of v3.9-rc1 results in a silent audio playback on my imx28-evk > > board. Can you confirm that on your side? > > Just tested and I confirm I see the same issue here on 3.9-rc1. > Ok, I drop both patches for now. Shawn
On Tue, Mar 5, 2013 at 11:21 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > On Tue, Mar 05, 2013 at 11:07:55AM -0300, Fabio Estevam wrote: >> On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: >> >> > I do not understand why. But it seems to me that applying the patch on >> > top of v3.9-rc1 results in a silent audio playback on my imx28-evk >> > board. Can you confirm that on your side? >> >> Just tested and I confirm I see the same issue here on 3.9-rc1. >> > Ok, I drop both patches for now. Reverting ad76fda7 fixes the issue. Will send a patch shortly.
On Tue, Mar 5, 2013 at 11:21 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Reverting ad76fda7 fixes the issue. Will send a patch shortly.
Sorry, this is not true. Will investigate more.
On Tue, Mar 5, 2013 at 11:25 AM, Fabio Estevam <festevam@gmail.com> wrote: > On Tue, Mar 5, 2013 at 11:21 AM, Fabio Estevam <festevam@gmail.com> wrote: > >> Reverting ad76fda7 fixes the issue. Will send a patch shortly. > > Sorry, this is not true. Will investigate more. Interesting that when I run 3.9.0-rc1-next-20130305 from my home network and I don't get any issues with audio playback + touchscreen.
Shawn, On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > I do not understand why. But it seems to me that applying the patch on > top of v3.9-rc1 results in a silent audio playback on my imx28-evk > board. Can you confirm that on your side? Can you please re-try against linux-next 20130322? I tried it here and audio playback is normal with touchscreen enabled.
On Fri, Mar 22, 2013 at 03:07:29PM -0300, Fabio Estevam wrote: > Shawn, > > On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > I do not understand why. But it seems to me that applying the patch on > > top of v3.9-rc1 results in a silent audio playback on my imx28-evk > > board. Can you confirm that on your side? > > Can you please re-try against linux-next 20130322? > Does it even boot for you? On my side, it stops at the point below. [ 1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget [ 1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller [ 1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1 > I tried it here and audio playback is normal with touchscreen enabled. You must have both patches below applied. 1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in 2) ARM: dts: imx28-evk: Enable touchscreen support I found that applying either one of the two without applying the other will result in a broken audio playback. That said, my mxs/soc branch gets a broken audio playback, and next-20130322 should be the same case, because both have the second patch not applied. I'm going to drop CONFIG_INPUT_EVDEV patch from my mxs/soc branch, and will not apply either of the two until the root cause of the broken audio playback gets identified. Shawn
On Sat, Mar 23, 2013 at 10:56 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > On Fri, Mar 22, 2013 at 03:07:29PM -0300, Fabio Estevam wrote: >> Shawn, >> >> On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: >> >> > I do not understand why. But it seems to me that applying the patch on >> > top of v3.9-rc1 results in a silent audio playback on my imx28-evk >> > board. Can you confirm that on your side? >> >> Can you please re-try against linux-next 20130322? >> > Does it even boot for you? On my side, it stops at the point below. > > [ 1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget > [ 1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller > [ 1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1 Same here. I forgot to mention I had to disable USB in order to complete the boot. This USB issue should be addressed separately though. > >> I tried it here and audio playback is normal with touchscreen enabled. > > You must have both patches below applied. > > 1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in > 2) ARM: dts: imx28-evk: Enable touchscreen support > > I found that applying either one of the two without applying the other > will result in a broken audio playback. With the USB support disabled, I don't see audio playback failure.
On Sat, Mar 23, 2013 at 03:09:52PM -0300, Fabio Estevam wrote: > On Sat, Mar 23, 2013 at 10:56 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > > On Fri, Mar 22, 2013 at 03:07:29PM -0300, Fabio Estevam wrote: > >> Shawn, > >> > >> On Mon, Mar 4, 2013 at 12:17 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > >> > >> > I do not understand why. But it seems to me that applying the patch on > >> > top of v3.9-rc1 results in a silent audio playback on my imx28-evk > >> > board. Can you confirm that on your side? > >> > >> Can you please re-try against linux-next 20130322? > >> > > Does it even boot for you? On my side, it stops at the point below. > > > > [ 1.600867] ci_hdrc ci_hdrc.0: doesn't support gadget > > [ 1.606282] ci_hdrc ci_hdrc.0: EHCI Host Controller > > [ 1.613522] ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1 > > Same here. I forgot to mention I had to disable USB in order to > complete the boot. This USB issue should be addressed separately > though. > Just figured it out that the problem is caused by usb phy Kconfig symbol shuffling. Just posted fixes. > > > >> I tried it here and audio playback is normal with touchscreen enabled. > > > > You must have both patches below applied. > > > > 1) ARM: mxs_defconfig: Build CONFIG_INPUT_EVDEV as built-in > > 2) ARM: dts: imx28-evk: Enable touchscreen support > > > > I found that applying either one of the two without applying the other > > will result in a broken audio playback. > > With the USB support disabled, I don't see audio playback failure. Yes, when testing on next-20130322, it seems audio playback works. But since when the patch gets applied on my mxs/dt branch, it breaks audio there, I still can not apply it. Shawn
Hi Shawn, On Sun, Mar 24, 2013 at 11:18 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > Yes, when testing on next-20130322, it seems audio playback works. But > since when the patch gets applied on my mxs/dt branch, it breaks audio > there, I still can not apply it. Could you please apply the touchscreen patch now?
On Mon, May 13, 2013 at 08:48:12AM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Sun, Mar 24, 2013 at 11:18 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > Yes, when testing on next-20130322, it seems audio playback works. But > > since when the patch gets applied on my mxs/dt branch, it breaks audio > > there, I still can not apply it. > > Could you please apply the touchscreen patch now? Have you tested it against v3.10-rc1? The issue is still there in my testing. Shawn
Dear Shawn Guo, > On Mon, May 13, 2013 at 08:48:12AM -0300, Fabio Estevam wrote: > > Hi Shawn, > > > > On Sun, Mar 24, 2013 at 11:18 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > Yes, when testing on next-20130322, it seems audio playback works. But > > > since when the patch gets applied on my mxs/dt branch, it breaks audio > > > there, I still can not apply it. > > > > Could you please apply the touchscreen patch now? > > Have you tested it against v3.10-rc1? The issue is still there in my > testing. Are the block handling touchscreen (lradc) and the block handling audio (sgtl5000+ssi) not two completely separate blocks? How can one influence the other? There is a possibility that there's some problem with broken clock bindings or clock structure maybe? That's the only thing that comes to mind that might cause it. Best regards, Marek Vasut
Hi Shawn, On Mon, May 13, 2013 at 11:31 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > Have you tested it against v3.10-rc1? The issue is still there in my > testing. I am not able to see the issue on 3.10-rc2. What are the exact steps to trigger the problem? Do you see it consistently?
On Mon, May 27, 2013 at 09:52:21PM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Mon, May 13, 2013 at 11:31 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > Have you tested it against v3.10-rc1? The issue is still there in my > > testing. > > I am not able to see the issue on 3.10-rc2. > My imx/dt branch is currently basing on v3.10-rc1, and I do not care if it works on v3.10-rc2. I have tested this patch enough on different bases, and I'm not going to test it again and again to find a base which happens to work. I do not feel comfortable to merge this patch if it only works on particular base. Who knows if it will break again with another random patches merged in. There is some issue, and we need to find the root cause of it instead of ignoring it by finding some random base which hides it. > What are the exact steps to trigger the problem? Do you see it consistently? Before I answer your questions, can I ask if you have tried to reproduce it on v3.10-rc1? Shawn
Dear Shawn Guo, > On Mon, May 27, 2013 at 09:52:21PM -0300, Fabio Estevam wrote: > > Hi Shawn, > > > > On Mon, May 13, 2013 at 11:31 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > > > Have you tested it against v3.10-rc1? The issue is still there in my > > > testing. > > > > I am not able to see the issue on 3.10-rc2. > > My imx/dt branch is currently basing on v3.10-rc1, and I do not care if > it works on v3.10-rc2. I have tested this patch enough on different > bases, and I'm not going to test it again and again to find a base which > happens to work. I do not feel comfortable to merge this patch if it > only works on particular base. Who knows if it will break again with > another random patches merged in. There is some issue, and we need to > find the root cause of it instead of ignoring it by finding some random > base which hides it. > > > What are the exact steps to trigger the problem? Do you see it > > consistently? > > Before I answer your questions, can I ask if you have tried to reproduce > it on v3.10-rc1? What is the problem you observe? Best regards, Marek Vasut
On Tue, May 28, 2013 at 06:56:27AM +0200, Marek Vasut wrote: > What is the problem you observe? > The audio playback gives silent output. Shawn
Dear Shawn Guo, > On Tue, May 28, 2013 at 06:56:27AM +0200, Marek Vasut wrote: > > What is the problem you observe? > > The audio playback gives silent output. You mean like nothing? Zilch? Not even a loud pop on the start/stop of playback? I have no issues with audio + touchscreen on m28evk since like 3.7 or so (even before I pushed the driver mainline), so this is weird. Do you have your speakers connected to LineOut or Speaker output from the SGTL5000 ? In case of LineOut, is your on-board amplifier on ? Best regards, Marek Vasut
On Tue, May 28, 2013 at 08:29:55PM +0200, Marek Vasut wrote: > Dear Shawn Guo, > > > On Tue, May 28, 2013 at 06:56:27AM +0200, Marek Vasut wrote: > > > What is the problem you observe? > > > > The audio playback gives silent output. > > You mean like nothing? Zilch? Not even a loud pop on the start/stop of playback? > Nothing. > I have no issues with audio + touchscreen on m28evk since like 3.7 or so (even > before I pushed the driver mainline), so this is weird. Do you have your > speakers connected to LineOut or Speaker output from the SGTL5000 ? In case of > LineOut, is your on-board amplifier on ? > Only headphone. Shawn
diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts index 2da316e..5960578 100644 --- a/arch/arm/boot/dts/imx28-evk.dts +++ b/arch/arm/boot/dts/imx28-evk.dts @@ -155,6 +155,7 @@ }; lradc@80050000 { + fsl,lradc-touchscreen-wires = <4>; status = "okay"; };