| Message ID | 1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12 February 2013 16:28, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > I have not checked the code but there is a possibility that custom pool->lock > is not needed at all due to dma_pool contains it's own lock. Your viewpoint is fine, but we wanted the reason behind this patch here. Please add appropriate stuff in only in logs. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/dma/coh901318_lli.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c > index 3e96610..702112d 100644 > --- a/drivers/dma/coh901318_lli.c > +++ b/drivers/dma/coh901318_lli.c > @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len) > dma_addr_t phy; > > if (len == 0) > - goto err; > + return NULL; > > spin_lock(&pool->lock); > > -- > 1.7.10.4 >
On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > I have not checked the code but there is a possibility that custom pool->lock > is not needed at all due to dma_pool contains it's own lock. Can you please change the description to something like: "The coh901318_lli allocator releases a lock on the exit path without taking it first". Which is what the patch is actually fixing. After that it's Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Feb 15, 2013 at 4:52 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > >> I have not checked the code but there is a possibility that custom pool->lock >> is not needed at all due to dma_pool contains it's own lock. > > Can you please change the description to something like: > > "The coh901318_lli allocator releases a lock on the exit path without > taking it first". In v2 (that by fact already applied) I put following description: In case the len is 0 we must return without trying to unlock the lock that was not locked. Does it fit your suggestion?
On Fri, Feb 15, 2013 at 3:56 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Feb 15, 2013 at 4:52 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >> >>> I have not checked the code but there is a possibility that custom pool->lock >>> is not needed at all due to dma_pool contains it's own lock. >> >> Can you please change the description to something like: >> >> "The coh901318_lli allocator releases a lock on the exit path without >> taking it first". > > In v2 (that by fact already applied) I put following description: > > In case the len is 0 we must return without trying to unlock the > lock that was > not locked. > > Does it fit your suggestion? Sure, acked-by. Thanks, Linus Walleij
diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c index 3e96610..702112d 100644 --- a/drivers/dma/coh901318_lli.c +++ b/drivers/dma/coh901318_lli.c @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len) dma_addr_t phy; if (len == 0) - goto err; + return NULL; spin_lock(&pool->lock);
I have not checked the code but there is a possibility that custom pool->lock is not needed at all due to dma_pool contains it's own lock. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-arm-kernel@lists.infradead.org --- drivers/dma/coh901318_lli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)