From patchwork Sun Feb 17 11:42:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haojian Zhuang X-Patchwork-Id: 2153071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id E2329DF283 for ; Sun, 17 Feb 2013 11:48:08 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U72fg-0008La-E0; Sun, 17 Feb 2013 11:44:40 +0000 Received: from mail-pa0-f47.google.com ([209.85.220.47]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U72fM-0008JZ-UU for linux-arm-kernel@lists.infradead.org; Sun, 17 Feb 2013 11:44:21 +0000 Received: by mail-pa0-f47.google.com with SMTP id bj3so2343694pad.20 for ; Sun, 17 Feb 2013 03:44:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=M/YRmKfj+95PVxoEouvjo7i6ZaiYJDqqRF0pp3VFoW0=; b=ZmYT8BWP7h5U+UYPCnRNcXkpB1QMifQmjCTUapAcVWw0Qn9LNipCkFTPTORdx7BxYn 2IY6RvrRk3qtzdxR2dZT+kX+B3A+oMO/dgxEol85t4wEJ3s5e/uOoO3y7l+3d6jJBSgR VGrVVxb4AzvzG7R+vnoWmviNbaJ+gpHbjJYqSGa26OLYc5xVm0GiQhnReUlOQTg/nq7I HCJ96EPmfsZ2Gtrs2JomKf68E2EIY93sNe5Xun39iVTlKBI5eEbylRgcttWGvbfsmBUP xGjvelNXLWDa/8hnrMs8q05gwEOMD8MOcxfwgCiRmtwKrbOFUAZTPFzROD9vBame5iah eoIg== X-Received: by 10.68.35.6 with SMTP id d6mr7804742pbj.167.1361101459521; Sun, 17 Feb 2013 03:44:19 -0800 (PST) Received: from localhost.localdomain ([67.198.145.34]) by mx.google.com with ESMTPS id hp7sm10927800pbc.8.2013.02.17.03.44.15 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Feb 2013 03:44:18 -0800 (PST) From: Haojian Zhuang To: shiraz.hashim@st.com, shiraz.linux.kernel@gmail.com, linux@arm.linux.org.uk, tony@atomide.com, linux-arm-kernel@lists.infradead.org, swarren@nvidia.com, grant.likely@secretlab.ca, linus.walleij@linaro.org Subject: [PATCH v9 02/10] gpio: fix wrong checking condition for gpio range Date: Sun, 17 Feb 2013 19:42:48 +0800 Message-Id: <1361101376-3783-3-git-send-email-haojian.zhuang@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1361101376-3783-1-git-send-email-haojian.zhuang@linaro.org> References: <1361101376-3783-1-git-send-email-haojian.zhuang@linaro.org> X-Gm-Message-State: ALoCoQnA6dxc9J+Bn1N7EENs1x7uFjjgEPZpg6DIMEDqIFVsTOBjuA3kVppf3hIUssgm7ITd7GuT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130217_064421_093710_2CA90A47 X-CRM114-Status: GOOD ( 10.61 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.47 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Haojian Zhuang , patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If index++ calculates from 0, the checking condition of "while (index++)" fails & it doesn't check any more. It doesn't follow the loop that used at here. Replace it by endless loop at here. Then it keeps parsing "gpio-ranges" property until it ends. Signed-off-by: Haojian Zhuang Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib-of.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 892040a..465f4ca 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -193,7 +193,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip) if (!np) return; - do { + for (;; index++) { ret = of_parse_phandle_with_args(np, "gpio-ranges", "#gpio-range-cells", index, &pinspec); if (ret) @@ -211,8 +211,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip) if (ret) break; - - } while (index++); + } } #else