From patchwork Fri Mar 8 11:09:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 2236831 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 8261D4006E for ; Fri, 8 Mar 2013 11:24:13 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDvLo-0008Hl-Ab; Fri, 08 Mar 2013 11:20:37 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDvLi-0008GO-Mg for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2013 11:20:33 +0000 Received: by mail-pa0-f49.google.com with SMTP id kp6so1234750pab.22 for ; Fri, 08 Mar 2013 03:20:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=wHMqOrjnSnLTtT5GCVxEBe14ejG+Ti70AHyv8QWSvrM=; b=fFGnuPeaNv4LVV4LIAvBe/vOyoNKcO+7byDogIxlyfXbF0dxj27HxdrIe9LnEiT/8N MSEVq6zdG8N1ZMtIfDABXvEWBwttQ1dU8t5DgSjVP/J/wT/9OrNf1pWfofIv9QzDL1N7 aCfo30t6McYHQdVnYZqcqJQgN5nyT4Pkk3fFtP1Dv29t++i7LsrcNWI9nBVYw7QnsWjr eADqeTL9TVkGGVRcK6V3RUi4McwzP/1lq9sFpmGIxbfs0ZWl6qRMWjLnUPXXwABVgUZF 7m20KPNTRbizAmG4uaatgIWuZ/kYhkcUM4oey8IslX+7L/a2B95cUSywpf5WrVcZC05s 1hsA== X-Received: by 10.68.136.42 with SMTP id px10mr2774811pbb.32.1362741625659; Fri, 08 Mar 2013 03:20:25 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id e7sm2798892pbm.10.2013.03.08.03.20.22 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Mar 2013 03:20:24 -0800 (PST) From: Tushar Behera To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower Date: Fri, 8 Mar 2013 16:39:48 +0530 Message-Id: <1362740988-16483-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmhiCHcmZwF3k1E5KYWN4dHCzuaKw90UXxAEsna20J+V3ssANKWjraNGDh1sNcwFcaYYdGb X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130308_062030_967444_DB638664 X-CRM114-Status: GOOD ( 12.55 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: kgene.kim@samsung.com, linux@arm.linux.org.uk, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower."), wfi macro should be used instead of the hardcoded WFI instruction. This fixes following oops when the kernel is compiled in Thumb-2 mode on EXYNOS5. (Tested on EXYNOS5250 based Arndale board) $ reboot Disabling non-boot CPUs ... IRQ153 no longer affine to CPU1 CPU1: shutdown Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2 Modules linked in: CPU: 1 Not tainted (3.9.0-rc1-00015-gce76372 #1) PC is at 0xc065858e LR is at exynos_cpu_die+0x53/0xc0 Signed-off-by: Tushar Behera --- arch/arm/mach-exynos/hotplug.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index c3f825b..d9712fe 100644 --- a/arch/arm/mach-exynos/hotplug.c +++ b/arch/arm/mach-exynos/hotplug.c @@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) if (cpu == 1) __raw_writel(0, S5P_ARM_CORE1_CONFIGURATION); - /* - * here's the WFI - */ - asm(".word 0xe320f003\n" - : - : - : "memory", "cc"); + wfi(); if (pen_release == cpu_logical_map(cpu)) { /*