[1/1] clk: Fix incorrect return type in clk.c

Commit Message

Sachin Kamat March 13, 2013, 9:47 a.m. UTC

Return type of function clk_propagate_rate_change is a pointer.
But 0 was being returned. Change it to NULL.
Silences the following warning:
drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat <[e-mail]>
---
 drivers/clk/clk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Pankaj Jangra March 13, 2013, 5:09 p.m. UTC | #1

Hi.

On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <[e-mail]> wrote:
> Return type of function clk_propagate_rate_change is a pointer.
> But 0 was being returned. Change it to NULL.
> Silences the following warning:
> drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <[e-mail]>
> ---
>  drivers/clk/clk.c |    2 +-

Looks good to me.
Reviewed-by: Pankaj Jangra <[e-mail]>

Regards,
Pankaj Jangra

Mike Turquette March 22, 2013, 7:19 p.m. UTC | #2

Quoting Pankaj Jangra (2013-03-13 10:09:18)
> Hi.
> 
> On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <[e-mail]> wrote:
> > Return type of function clk_propagate_rate_change is a pointer.
> > But 0 was being returned. Change it to NULL.
> > Silences the following warning:
> > drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Sachin Kamat <[e-mail]>
> > ---
> >  drivers/clk/clk.c |    2 +-
> 
> Looks good to me.
> Reviewed-by: Pankaj Jangra <[e-mail]>
> 

Thanks for the fix.  Taken into clk-next.

Regards,
Mike

> Regards,
> Pankaj Jangra

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ed87b24..467b31f 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -974,7 +974,7 @@  static struct clk *clk_propagate_rate_change(struct clk *clk, unsigned long even
 	int ret = NOTIFY_DONE;
 
 	if (clk->rate == clk->new_rate)
-		return 0;
+		return NULL;
 
 	if (clk->notifier_count) {
 		ret = __clk_notify(clk, event, clk->rate, clk->new_rate);