| Message ID | 1363266691-15757-10-git-send-email-fabio.porcedda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Fabio, On Thu, Mar 14, 2013 at 02:11:29PM +0100, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/mfd/davinci_voicecodec.c | 12 +----------- > drivers/mfd/htc-pasic3.c | 13 +------------ > 2 files changed, 2 insertions(+), 23 deletions(-) Jingoo Han sent a larger patchset to convert many MFD drivers to module_platform_driver_probe(), including htc-pasic3 and davinci_voicecodec. See my mfd-next tree for more details. Cheers, Samuel.
On Tue, Apr 9, 2013 at 10:06 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > Hi Fabio, > > On Thu, Mar 14, 2013 at 02:11:29PM +0100, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Samuel Ortiz <sameo@linux.intel.com> >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> drivers/mfd/davinci_voicecodec.c | 12 +----------- >> drivers/mfd/htc-pasic3.c | 13 +------------ >> 2 files changed, 2 insertions(+), 23 deletions(-) > Jingoo Han sent a larger patchset to convert many MFD drivers to > module_platform_driver_probe(), including htc-pasic3 and davinci_voicecodec. > > See my mfd-next tree for more details. I understand, thanks for letting me know. It's my fault for having waited too long to send this patch set. Best regards -- Fabio Porcedda > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/
diff --git a/drivers/mfd/davinci_voicecodec.c b/drivers/mfd/davinci_voicecodec.c index c0bcc87..c60ab0c 100644 --- a/drivers/mfd/davinci_voicecodec.c +++ b/drivers/mfd/davinci_voicecodec.c @@ -177,17 +177,7 @@ static struct platform_driver davinci_vc_driver = { .remove = davinci_vc_remove, }; -static int __init davinci_vc_init(void) -{ - return platform_driver_probe(&davinci_vc_driver, davinci_vc_probe); -} -module_init(davinci_vc_init); - -static void __exit davinci_vc_exit(void) -{ - platform_driver_unregister(&davinci_vc_driver); -} -module_exit(davinci_vc_exit); +module_platform_driver_probe(davinci_vc_driver, davinci_vc_probe); MODULE_AUTHOR("Miguel Aguilar"); MODULE_DESCRIPTION("Texas Instruments DaVinci Voice Codec Core Interface"); diff --git a/drivers/mfd/htc-pasic3.c b/drivers/mfd/htc-pasic3.c index 9e5453d..0285fce 100644 --- a/drivers/mfd/htc-pasic3.c +++ b/drivers/mfd/htc-pasic3.c @@ -208,18 +208,7 @@ static struct platform_driver pasic3_driver = { .remove = pasic3_remove, }; -static int __init pasic3_base_init(void) -{ - return platform_driver_probe(&pasic3_driver, pasic3_probe); -} - -static void __exit pasic3_base_exit(void) -{ - platform_driver_unregister(&pasic3_driver); -} - -module_init(pasic3_base_init); -module_exit(pasic3_base_exit); +module_platform_driver_probe(pasic3_driver, pasic3_probe); MODULE_AUTHOR("Philipp Zabel <philipp.zabel@gmail.com>"); MODULE_DESCRIPTION("Core driver for HTC PASIC3");
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: linux-arm-kernel@lists.infradead.org --- drivers/mfd/davinci_voicecodec.c | 12 +----------- drivers/mfd/htc-pasic3.c | 13 +------------ 2 files changed, 2 insertions(+), 23 deletions(-)