From patchwork Wed Mar 27 11:02:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 2349731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id EF709DFE82 for ; Wed, 27 Mar 2013 11:15:23 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UKoHX-0004XI-KA; Wed, 27 Mar 2013 11:12:39 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UKoB2-0001lZ-Je for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2013 11:05:58 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MKB0078IG5PMTQ0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2013 20:05:55 +0900 (KST) X-AuditID: cbfee61b-b7f076d0000034b6-7d-5152d2939ba5 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9C.F2.13494.392D2515; Wed, 27 Mar 2013 20:05:55 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MKB00EJ7G19TVH0@mmp2.samsung.com>; Wed, 27 Mar 2013 20:05:55 +0900 (KST) From: Tomasz Figa To: linux-samsung-soc@vger.kernel.org Subject: [PATCH 08/21] clk: samsung: pll: Remove unimplemented ops Date: Wed, 27 Mar 2013 12:02:45 +0100 Message-id: <1364382178-25248-9-git-send-email-t.figa@samsung.com> X-Mailer: git-send-email 1.7.10 In-reply-to: <1364382178-25248-1-git-send-email-t.figa@samsung.com> References: <1364382178-25248-1-git-send-email-t.figa@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsVy+t9jQd3Jl4ICDfr7xCxurTvHatG74Cqb xdmmN+wWbx5uZrTY9Pgaq8WM8/uYLNYeuctu8XTCRTaLw2/aWS3Wz3jNYnFsxhJGB26PO9f2 sHlsXlLv0bdlFaPH501yASxRXDYpqTmZZalF+nYJXBmLFnWzF+xTrjgy9QJbA+MB2S5GTg4J AROJGYvesEDYYhIX7q1n62Lk4hASmM4oMefNchYIp4tJ4t6KO+wgVWwCahKfGx6xgdgiAqoS n9sWgMWZBVqZJBaetwSxhQWcJI7MPsoEYrMA1TR8Xga2gRco3jnjPSPENnmJp/f7wOZwCjhL vJt+BCwuBFRz481T1gmMvAsYGVYxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBIfcM+kdjKsa LA4xCnAwKvHwOvwLDBRiTSwrrsw9xCjBwawkwmt0IChQiDclsbIqtSg/vqg0J7X4EKM0B4uS OO/BVutAIYH0xJLU7NTUgtQimCwTB6dUA2NFb4Fo54I1ldKeidXWc/e1vj8bathx7c87wW6W /glc8682yXhN4sp7yfHCuZhnW8q2wKTKb4b//n10v2X5Rvcco/rBVK7X+o2mdvNMls7p4zme b7X2/btbN47fsYhTWsLOfkboxmQFq+NZm2SWfV+5K8VCIVGV+3vBOTutPefaDl1raAt4lqrE UpyRaKjFXFScCADortMQNQIAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130327_070556_932114_6802BE6F X-CRM114-Status: UNSURE ( 8.09 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -8.2 (--------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-8.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.3 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: l.majewski@samsung.com, kgene.kim@samsung.com, mturquette@linaro.org, t.figa@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, thomas.abraham@linaro.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Unimplemented clock operations should be simply omitted instead of returning error values. This patch removes unimplemented PLL operations to fix problems caused by returning error code in round_rate callback. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/clk/samsung/clk-pll.c | 80 ------------------------------------------- 1 file changed, 80 deletions(-) diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index 4b24511..89135f6 100644 --- a/drivers/clk/samsung/clk-pll.c +++ b/drivers/clk/samsung/clk-pll.c @@ -49,24 +49,8 @@ static unsigned long samsung_pll35xx_recalc_rate(struct clk_hw *hw, return (unsigned long)fvco; } -/* todo: implement pl35xx clock round rate operation */ -static long samsung_pll35xx_round_rate(struct clk_hw *hw, - unsigned long drate, unsigned long *prate) -{ - return -ENOTSUPP; -} - -/* todo: implement pl35xx clock set rate */ -static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate, - unsigned long prate) -{ - return -ENOTSUPP; -} - static const struct clk_ops samsung_pll35xx_clk_ops = { .recalc_rate = samsung_pll35xx_recalc_rate, - .round_rate = samsung_pll35xx_round_rate, - .set_rate = samsung_pll35xx_set_rate, }; struct clk * __init samsung_clk_register_pll35xx(const char *name, @@ -144,24 +128,8 @@ static unsigned long samsung_pll36xx_recalc_rate(struct clk_hw *hw, return (unsigned long)fvco; } -/* todo: implement pl36xx clock round rate operation */ -static long samsung_pll36xx_round_rate(struct clk_hw *hw, - unsigned long drate, unsigned long *prate) -{ - return -ENOTSUPP; -} - -/* todo: implement pl36xx clock set rate */ -static int samsung_pll36xx_set_rate(struct clk_hw *hw, unsigned long drate, - unsigned long prate) -{ - return -ENOTSUPP; -} - static const struct clk_ops samsung_pll36xx_clk_ops = { .recalc_rate = samsung_pll36xx_recalc_rate, - .round_rate = samsung_pll36xx_round_rate, - .set_rate = samsung_pll36xx_set_rate, }; struct clk * __init samsung_clk_register_pll36xx(const char *name, @@ -239,24 +207,8 @@ static unsigned long samsung_pll45xx_recalc_rate(struct clk_hw *hw, return (unsigned long)fvco; } -/* todo: implement pl45xx clock round rate operation */ -static long samsung_pll45xx_round_rate(struct clk_hw *hw, - unsigned long drate, unsigned long *prate) -{ - return -ENOTSUPP; -} - -/* todo: implement pl45xx clock set rate */ -static int samsung_pll45xx_set_rate(struct clk_hw *hw, unsigned long drate, - unsigned long prate) -{ - return -ENOTSUPP; -} - static const struct clk_ops samsung_pll45xx_clk_ops = { .recalc_rate = samsung_pll45xx_recalc_rate, - .round_rate = samsung_pll45xx_round_rate, - .set_rate = samsung_pll45xx_set_rate, }; struct clk * __init samsung_clk_register_pll45xx(const char *name, @@ -342,24 +294,8 @@ static unsigned long samsung_pll46xx_recalc_rate(struct clk_hw *hw, return (unsigned long)fvco; } -/* todo: implement pl46xx clock round rate operation */ -static long samsung_pll46xx_round_rate(struct clk_hw *hw, - unsigned long drate, unsigned long *prate) -{ - return -ENOTSUPP; -} - -/* todo: implement pl46xx clock set rate */ -static int samsung_pll46xx_set_rate(struct clk_hw *hw, unsigned long drate, - unsigned long prate) -{ - return -ENOTSUPP; -} - static const struct clk_ops samsung_pll46xx_clk_ops = { .recalc_rate = samsung_pll46xx_recalc_rate, - .round_rate = samsung_pll46xx_round_rate, - .set_rate = samsung_pll46xx_set_rate, }; struct clk * __init samsung_clk_register_pll46xx(const char *name, @@ -441,24 +377,8 @@ static unsigned long samsung_pll2550x_recalc_rate(struct clk_hw *hw, return (unsigned long)fvco; } -/* todo: implement pl2550x clock round rate operation */ -static long samsung_pll2550x_round_rate(struct clk_hw *hw, - unsigned long drate, unsigned long *prate) -{ - return -ENOTSUPP; -} - -/* todo: implement pl2550x clock set rate */ -static int samsung_pll2550x_set_rate(struct clk_hw *hw, unsigned long drate, - unsigned long prate) -{ - return -ENOTSUPP; -} - static const struct clk_ops samsung_pll2550x_clk_ops = { .recalc_rate = samsung_pll2550x_recalc_rate, - .round_rate = samsung_pll2550x_round_rate, - .set_rate = samsung_pll2550x_set_rate, }; struct clk * __init samsung_clk_register_pll2550x(const char *name,