From patchwork Sat Mar 30 08:21:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Fritz X-Patchwork-Id: 2367201 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 4F970DF24C for ; Sat, 30 Mar 2013 08:25:21 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ULr2i-00075C-3x; Sat, 30 Mar 2013 08:21:40 +0000 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ULr2e-00074t-Rs for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2013 08:21:37 +0000 Received: by mail-ea0-f182.google.com with SMTP id q15so469246ead.13 for ; Sat, 30 Mar 2013 01:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:subject:from:to:content-type:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=MrNq3XSd6Cjys7wKu/NRektLbc0nHxHmic1YB4T7nfU=; b=sVdGEGh+uPcFf0ocdbIh8FHaUujoKjorMIcaYKmfHk8Ejce0XRiCmE8sP9UEHLZu+G WCSD0FiTZXtjNfCPUgO6ZRkpgzEi2r8Hy3CZ37lVe1G6Qf1Lwu51hh1HYEF+mO6pJZCz qvJbTywrkTluf96eQwvcONPz8GEGgPraVK+J3Gz0dOhunh3ALhvNVXUdz0YlhMe33D8u hFCMOlR215ISxm/PyhXLQGK9Tyf0gN8WL5JeaIdWit0Sg9UeRr5QkEpzohlXCxe9XhUc ZzEOBzeIFSNZGG/PTZdqmw83H3PP9o2mCkD9UGX3olm6qHo4b30nqa8q9dJ/PwgUlS0V owHw== X-Received: by 10.14.179.5 with SMTP id g5mr15852596eem.41.1364631692820; Sat, 30 Mar 2013 01:21:32 -0700 (PDT) Received: from [192.168.1.12] (p549EA386.dip.t-dialin.net. [84.158.163.134]) by mx.google.com with ESMTPS id q5sm8360882eeo.17.2013.03.30.01.21.30 (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 30 Mar 2013 01:21:31 -0700 (PDT) Subject: [RFC][BUG] arm/dts: OMAP3: set #interrupt-cells to two From: Christoph Fritz To: =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Russell King , linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Tarun Kanti DebBarma , Daniel Mack , "Hans J. Koch" Date: Sat, 30 Mar 2013 09:21:28 +0100 Message-ID: <1364631689.3767.7.camel@mars> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130330_042137_120668_F56DEB0F X-CRM114-Status: GOOD ( 11.70 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (chf.fritz[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This patch sets gpio #interrupt-cells from a falsely acquired '1' to '2' referring to Documentation/devicetree/bindings/gpio/gpio-omap.txt: The first cell is the GPIO number. The second cell is used to specify flags: bits[3:0] trigger type and level flags: 1 = low-to-high edge triggered. 2 = high-to-low edge triggered. 4 = active high level-sensitive. 8 = active low level-sensitive. But using this trigger cell in a board specific devicetree leads to a non-starting kernel. This is due to not yet enabled gpio-clocks while kernel/irq/irqdomain.c tries to set this trigger-flag (from the second interrupt-cell) to gpio-irq-controller. Any ideas? --- arch/arm/boot/dts/omap3.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 1997b41..e8e6b8f 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -99,7 +99,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; gpio2: gpio@49050000 { @@ -108,7 +108,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; gpio3: gpio@49052000 { @@ -117,7 +117,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; gpio4: gpio@49054000 { @@ -126,7 +126,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; gpio5: gpio@49056000 { @@ -135,7 +135,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; gpio6: gpio@49058000 { @@ -144,7 +144,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <1>; + #interrupt-cells = <2>; }; uart1: serial@4806a000 {