From patchwork Mon Apr 8 16:58:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 2410401 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id B30483FC71 for ; Mon, 8 Apr 2013 16:58:43 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPFOy-0003U1-RR; Mon, 08 Apr 2013 16:58:41 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPFOv-0003dT-7v; Mon, 08 Apr 2013 16:58:37 +0000 Received: from mail-ia0-f202.google.com ([209.85.210.202]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPFOr-0003cs-Ux for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2013 16:58:34 +0000 Received: by mail-ia0-f202.google.com with SMTP id p22so1508864iad.3 for ; Mon, 08 Apr 2013 09:58:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=MVJDtCdnn5bq04WMk1LAyqbUPaU4T3YhC7cVCN8p88o=; b=Hk+zLphvWwoLthW264eOMRVOMhNyRPnZKGNJ7ek3a6Fx7xCEm5jj8+osbZh6Wjg3ic ZzQX8R8itSOR+2Fkn612HPOoDR98N6Gkpda6HokxjNSkqhYtEu5HCKkp1H0k8fU3EXm/ X6GYLgivq9Pjr7yikTMzrG1ZWB6ClKQZ2GNC/xaD42vWtbVktcjC8z9mEHJY8OfDXqtX cKXIXSPXetgutzHbs6/KE99wP7U2gKGz1+op8OT03a/uQja7/1wtf9JKow1YUmp4xYF6 uIfJwtV0Rij8qLMvYdQ1L9How890aiPAidrNHlOnOlQu3JUXJGBiwDH8vbgVDtine9gS FiIA== X-Received: by 10.43.136.5 with SMTP id ii5mr16923819icc.11.1365440307818; Mon, 08 Apr 2013 09:58:27 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id hn12si1669997igb.3.2013.04.08.09.58.27 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 08 Apr 2013 09:58:27 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.162.34]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id B128A5A42A5; Mon, 8 Apr 2013 09:58:26 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 45E57811BE; Mon, 8 Apr 2013 09:58:26 -0700 (PDT) From: Doug Anderson To: Kukjin Kim Subject: [PATCH] ARM: dts: Disable the RTC by default on exynos5 Date: Mon, 8 Apr 2013 09:58:15 -0700 Message-Id: <1365440295-4460-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.8.1.3 X-Gm-Message-State: ALoCoQn3H2DfBO/yu4OglwogAPuT5YQ+jVD2JZDWKHvBK/XK4loJqMmVu8TfP5x6k+2QqBSLU9C1wt6qP8/YhcZtMIE4iKn2rXMTzNwHfOXsKa6Cw74roALKcgn5LJNL1vBdgjHtI57QLmGm6R+aZJZm3tOeLcYK5Vvd5nUPD45IfIzvono8ecZU102O97/MDUra7sWfeOI2izoHba+hY809YxmM+yAHYg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130408_125834_069060_9500D30F X-CRM114-Status: GOOD ( 12.88 ) X-Spam-Score: -3.2 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.202 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -2.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-samsung-soc@vger.kernel.org, Russell King , Padmavathi Venna , Giridhar Maruthy , Jingoo Han , Doug Anderson , linux-kernel@vger.kernel.org, Thomas Abraham , Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This change makes the rtc on the exynos5250 and 5440 disabled by default to match exynos4. Ever since the common clock framework came in came in, exynos5250 boards have dumped lots of warnings in the boot log. It turns out that we don't see those on exynos4 since the rtc is disabled by default. While we need to get to the bottom of the problems with the RTC, it still makes sense to have the default state of the RTC on exynos boards match. For the record, warnings look like this: ------------[ cut here ]------------ WARNING: at /.../drivers/clk/clk.c:771 __clk_enable+0x34/0xb0() Modules linked in: [<80015bfc>] (unwind_backtrace+0x0/0xec) from [<804717f0>] (dump_stack+0x20/0x24) [<804717f0>] (dump_stack+0x20/0x24) from [<80023cd0>] (warn_slowpath_common+0x5c/0x7c) [<80023cd0>] (warn_slowpath_common+0x5c/0x7c) from [<80023d1c>] (warn_slowpath_null+0x2c/0x34) [<80023d1c>] (warn_slowpath_null+0x2c/0x34) from [<8035ddb0>] (__clk_enable+0x34/0xb0) [<8035ddb0>] (__clk_enable+0x34/0xb0) from [<8035de54>] (clk_enable+0x28/0x3c) [<8035de54>] (clk_enable+0x28/0x3c) from [<8031a160>] (s3c_rtc_probe+0xf4/0x434) [<8031a160>] (s3c_rtc_probe+0xf4/0x434) from [<8028e288>] (platform_drv_probe+0x24/0x28) [<8028e288>] (platform_drv_probe+0x24/0x28) from [<8028ce10>] (driver_probe_device+0xbc/0x22c) [<8028ce10>] (driver_probe_device+0xbc/0x22c) from [<8028cff8>] (__driver_attach+0x78/0x9c) [<8028cff8>] (__driver_attach+0x78/0x9c) from [<8028bdfc>] (bus_for_each_dev+0x64/0xac) [<8028bdfc>] (bus_for_each_dev+0x64/0xac) from [<8028c7e0>] (driver_attach+0x28/0x30) [<8028c7e0>] (driver_attach+0x28/0x30) from [<8028c43c>] (bus_add_driver+0xe0/0x234) [<8028c43c>] (bus_add_driver+0xe0/0x234) from [<8028d55c>] (driver_register+0xac/0x13c) [<8028d55c>] (driver_register+0xac/0x13c) from [<8028e4f4>] (platform_driver_register+0x54/0x68) [<8028e4f4>] (platform_driver_register+0x54/0x68) from [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c) [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c) from [<800086d8>] (do_one_initcall+0x60/0x138) [<800086d8>] (do_one_initcall+0x60/0x138) from [<80633a8c>] (kernel_init_freeable+0x108/0x1d0) [<80633a8c>] (kernel_init_freeable+0x108/0x1d0) from [<8046d2f8>] (kernel_init+0x1c/0xf4) [<8046d2f8>] (kernel_init+0x1c/0xf4) from [<8000e358>] (ret_from_fork+0x14/0x20) ---[ end trace 4bcdc801c868d73f ]--- Signed-off-by: Doug Anderson --- arch/arm/boot/dts/exynos5250.dtsi | 1 + arch/arm/boot/dts/exynos5440.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index dc55e33..892b724 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -183,6 +183,7 @@ interrupts = <0 43 0>, <0 44 0>; clocks = <&clock 337>; clock-names = "rtc"; + status = "disabled"; }; tmu@10060000 { diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index 25c6134..a8ceef4 100644 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -181,5 +181,6 @@ interrupts = <0 17 0>, <0 16 0>; clocks = <&clock 21>; clock-names = "rtc"; + status = "disabled"; }; };