From patchwork Thu Apr 25 00:19:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 2486941 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 2514DDF25A for ; Thu, 25 Apr 2013 00:19:34 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UV9uK-0006qr-Bb; Thu, 25 Apr 2013 00:19:28 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UV9uH-0005tM-ID; Thu, 25 Apr 2013 00:19:25 +0000 Received: from mail-pd0-f173.google.com ([209.85.192.173]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UV9uD-0005sl-No for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2013 00:19:22 +0000 Received: by mail-pd0-f173.google.com with SMTP id v14so112952pde.18 for ; Wed, 24 Apr 2013 17:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=ysePewIRJg9SHdeLVrDoy5eg1Jl8z9moTyouqYWmpa0=; b=BQrRm4QjfmXtYPKyMdW5ch7uFxntzcp4jYYZriPbStEiBPFLw2nff6RbnoCuJ78IJI qZ+y22kqTkl1PHzavjVvHRF8cmDs2Wzuz383kd24zyHlh5cfuMJqyoFI9RWyu1bwUINj 1LXvKyuPwJlrDYk/bGdUcKzifXrqnFUWCWRds9BFEZHZaPAwoto6I1B9uMODIpFXij0K NHcWbmzIc+YnnsF753yi/C7sZEkKXDsd0aR4xzMTIwRf44ReDgWc5p6FbTWyxgGP9yW6 ZilWnIju0hdlN7i3LDKHQnIYrIMQnLlvGoj3h3yAjUCyycuvKFV7AiTa9/tDXxAKPgQV xdIQ== X-Received: by 10.68.196.33 with SMTP id ij1mr50162768pbc.203.1366849157216; Wed, 24 Apr 2013 17:19:17 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPSA id iy2sm4844514pbb.31.2013.04.24.17.19.15 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 24 Apr 2013 17:19:16 -0700 (PDT) From: Kevin Hilman To: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle Date: Wed, 24 Apr 2013 17:19:13 -0700 Message-Id: <1366849153-25564-1-git-send-email-khilman@linaro.org> X-Mailer: git-send-email 1.8.2 X-Gm-Message-State: ALoCoQn/P/bDuuGdk1xhgaW3vRIPkIT2Ry/cMrjdv71KjmBd8eY9rm67NqR1OX2zmNoCTg9DFtGu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130424_201921_860411_0C18C159 X-CRM114-Status: GOOD ( 12.90 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.192.173 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linaro-kernel@lists.linaro.org, Peter Zijlstra , Rusty Russell , Magnus Damm , "Srivatsa S. Bhat" , Paul McKenney , Linus Torvalds , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org commit d1669912 (idle: Implement generic idle function) added a new generic idle along with support for hlt/nohlt command line options to override default idle loop behavior. However, the command-line processing is never compiled. The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP and arches that use this feature select it in their Kconfigs. However, no Kconfig definition was created for this option, so it is never enabled, and therefore command-line override of the idle-loop behavior is broken after migrating to the generic idle loop. To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP. Tested on ARM (OMAP4/Panda) which enables the command-line overrides by default. Cc: Thomas Gleixner Cc: Linus Torvalds Cc: Rusty Russell Cc: Paul McKenney Cc: Peter Zijlstra Cc: Srivatsa S. Bhat Cc: Magnus Damm Signed-off-by: Kevin Hilman Reviewed-by: Srivatsa S. Bhat --- Applies on tip/smp/hotplug where generic idle feature is added arch/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 1455579..e0ef57b 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS config GENERIC_SMP_IDLE_THREAD bool +config GENERIC_IDLE_POLL_SETUP + bool + # Select if arch init_task initializer is different to init/init_task.c config ARCH_INIT_TASK bool