From patchwork Fri Apr 26 20:02:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 2495731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 924823FC64 for ; Fri, 26 Apr 2013 20:06:54 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UVotZ-0006uQ-NS; Fri, 26 Apr 2013 20:05:28 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UVot0-0004N6-Om; Fri, 26 Apr 2013 20:04:50 +0000 Received: from mail-ea0-x22e.google.com ([2a00:1450:4013:c01::22e]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UVosX-0004K2-NW for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2013 20:04:23 +0000 Received: by mail-ea0-f174.google.com with SMTP id g14so426460eak.5 for ; Fri, 26 Apr 2013 13:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=fwPqX/VQLtPv2S+0m6504issxLFgYIPpbrI73URXvE8=; b=R7H5sIWCx4xHvhrICgd4KpleAmoAQUWTdmFXPTs1O7YQEQH8Q68RRpj435DfsBl3Ry dKFeHnDpKQowPnnX8vnXhLjqdhxI9kVOLLoc1CP2t7i3tPr5W8PsuEAUQx5fSvl3tjQZ bvyvP7j51IIySIpMSaVhnL+3Uc2tUkiYG1/JocyjsE0PyMEV/8E1qAQJhTGRx+HmWbkP txRh1N8MOLtoqq9kDZD1DJdxSMI+w1M1/UokMkVPJz2K+WDKZA6Lo+rjnOxOFSso+6QA LawNn5SF/5DIX07FpvKslboKUBHnIwaL6hz2x4Jleih3ecSG8npI5eEiHZEz/J18NC74 v1Cw== X-Received: by 10.15.36.135 with SMTP id i7mr59262921eev.34.1367006659846; Fri, 26 Apr 2013 13:04:19 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPSA id cd3sm17841788eeb.6.2013.04.26.13.04.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 26 Apr 2013 13:04:19 -0700 (PDT) From: Sylwester Nawrocki To: kgene.kim@samsung.com, FlorianSchandinat@gmx.de Subject: [PATCH 5/9] s3c2410fb: Use dev_pm_ops Date: Fri, 26 Apr 2013 22:02:19 +0200 Message-Id: <1367006543-5458-6-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1367006543-5458-1-git-send-email-sylvester.nawrocki@gmail.com> References: <1367006543-5458-1-git-send-email-sylvester.nawrocki@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130426_160421_984852_02EA8575 X-CRM114-Status: GOOD ( 15.47 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sylvester.nawrocki[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Use the driver PM ops rather than legacy suspend/resume callbacks. Also use CONFIG_PM_SLEEP switch to compile in the system sleep code instead of CONFIG_PM. Signed-off-by: Sylwester Nawrocki --- drivers/video/s3c2410fb.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index d6706f7..479ab45 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -36,10 +37,6 @@ #include #include -#ifdef CONFIG_PM -#include -#endif - #include "s3c2410fb.h" /* Debugging stuff */ @@ -1044,8 +1041,7 @@ static int s3c2410fb_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM - +#ifdef CONFIG_PM_SLEEP /* suspend and resume support for the lcd controller */ static int s3c2410fb_suspend(struct platform_device *dev, pm_message_t state) { @@ -1081,9 +1077,14 @@ static int s3c2410fb_resume(struct platform_device *dev) return 0; } +static const struct dev_pm_ops s3c2410fb_pm_ops = { + .resume = s3c2410fb_resume, + .suspend = s3c2410fb_suspend, +}; + +#define S3C2410FB_PM_OPS (&s3c2410fb_pm_ops) #else -#define s3c2410fb_suspend NULL -#define s3c2410fb_resume NULL +#define S3C2410FB_PM_OPS (NULL) #endif static struct platform_device_id s3c2410fb_driver_ids[] = { @@ -1099,12 +1100,11 @@ static struct platform_device_id s3c2410fb_driver_ids[] = { static struct platform_driver s3c2410fb_driver = { .probe = s3c2410fb_probe, .remove = s3c2410fb_remove, - .suspend = s3c2410fb_suspend, - .resume = s3c2410fb_resume, .id_table = s3c2410fb_driver_ids, .driver = { .name = "s3c2410-lcd", .owner = THIS_MODULE, + .pm = S3C2410FB_PM_OPS, }, };