| Message ID | 1367039198-28639-1-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Saturday 27 April 2013, Alexander Shiyan wrote: > Patch adds GENERIC_ALLOCATOR, if "coda" is selected. > > drivers/built-in.o: In function `coda_remove': > :(.text+0x110634): undefined reference to `gen_pool_free' > drivers/built-in.o: In function `coda_probe': > :(.text+0x1107d4): undefined reference to `of_get_named_gen_pool' > :(.text+0x1108b8): undefined reference to `gen_pool_alloc' > :(.text+0x1108d0): undefined reference to `gen_pool_virt_to_phys' > :(.text+0x110918): undefined reference to `dev_get_gen_pool' > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Acked-by: Arnd Bergmann <arnd@arndb.de> I noticed the problem as well, but haven't gotten around to create a patch. Thanks for taking care of this! Arnd
Alexander/Arnd, On Sat, Apr 27, 2013 at 12:33 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Saturday 27 April 2013, Alexander Shiyan wrote: >> Patch adds GENERIC_ALLOCATOR, if "coda" is selected. >> >> drivers/built-in.o: In function `coda_remove': >> :(.text+0x110634): undefined reference to `gen_pool_free' >> drivers/built-in.o: In function `coda_probe': >> :(.text+0x1107d4): undefined reference to `of_get_named_gen_pool' >> :(.text+0x1108b8): undefined reference to `gen_pool_alloc' >> :(.text+0x1108d0): undefined reference to `gen_pool_virt_to_phys' >> :(.text+0x110918): undefined reference to `dev_get_gen_pool' >> >> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > I noticed the problem as well, but haven't gotten around to create > a patch. Thanks for taking care of this! I fixed this issue in a different way: https://patchwork.kernel.org/patch/2432841/ And Shawn has already queued it.
On Saturday 27 April 2013, Fabio Estevam wrote: > I fixed this issue in a different way: > https://patchwork.kernel.org/patch/2432841/ > > And Shawn has already queued it. Ok, that's probably better. Arnd
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 0cbe1ff..414a769 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -145,6 +145,7 @@ config VIDEO_CODA depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV + select GENERIC_ALLOCATOR ---help--- Coda is a range of video codec IPs that supports H.264, MPEG-4, and other video formats.
Patch adds GENERIC_ALLOCATOR, if "coda" is selected. drivers/built-in.o: In function `coda_remove': :(.text+0x110634): undefined reference to `gen_pool_free' drivers/built-in.o: In function `coda_probe': :(.text+0x1107d4): undefined reference to `of_get_named_gen_pool' :(.text+0x1108b8): undefined reference to `gen_pool_alloc' :(.text+0x1108d0): undefined reference to `gen_pool_virt_to_phys' :(.text+0x110918): undefined reference to `dev_get_gen_pool' Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/media/platform/Kconfig | 1 + 1 file changed, 1 insertion(+)