| Message ID | 1370066053-25030-4-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Jun 01, 2013 at 09:54:13AM +0400, Alexander Shiyan wrote: > Patch adds initial dts for Phytec PCM970 Rapid development kit. > - Added definition for UART0 and UART1. > - Added additional SPI chipselect which used on RDK for ZegBee module. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 29 ++++++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 8450c14..eee371f 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -108,6 +108,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ > imx27-apf27dev.dtb \ > imx27-pdk.dtb \ > imx27-phytec-phycore-som.dtb \ > + imx27-phytec-phycore-rdk.dtb \ > imx31-bug.dtb \ > imx51-apf51.dtb \ > imx51-apf51dev.dtb \ > diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > new file mode 100644 > index 0000000..f8a7a49 > --- /dev/null > +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > @@ -0,0 +1,29 @@ > +/* > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +#include "imx27-phytec-phycore-som.dts" > + > +/ { > + model = "Phytec pcm970"; > + compatible = "phytec,imx27-pcm970", "phytec,imx27-pcm038", "fsl,imx27"; > +}; > + > +&cspi1 { > + fsl,spi-num-chipselects = <2>; > + cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>; > +}; The first chipselect connects to the mc13783 PMIC which is on the module, not on the baseboard. Also this is a no-op since the status property of the cspi is not changed to 'okay'. I suspect you already have a patch adding mc13783 support to the module which should be in this series ;) Sascha
> On Sat, Jun 01, 2013 at 09:54:13AM +0400, Alexander Shiyan wrote: > > Patch adds initial dts for Phytec PCM970 Rapid development kit. > > - Added definition for UART0 and UART1. > > - Added additional SPI chipselect which used on RDK for ZegBee module. > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 29 ++++++++++++++++++++++++++ > > 2 files changed, 30 insertions(+) > > create mode 100644 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 8450c14..eee371f 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -108,6 +108,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ > > imx27-apf27dev.dtb \ > > imx27-pdk.dtb \ > > imx27-phytec-phycore-som.dtb \ > > + imx27-phytec-phycore-rdk.dtb \ > > imx31-bug.dtb \ > > imx51-apf51.dtb \ > > imx51-apf51dev.dtb \ > > diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > new file mode 100644 > > index 0000000..f8a7a49 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > @@ -0,0 +1,29 @@ > > +/* > > + * The code contained herein is licensed under the GNU General Public > > + * License. You may obtain a copy of the GNU General Public License > > + * Version 2 or later at the following locations: > > + * > > + * http://www.opensource.org/licenses/gpl-license.html > > + * http://www.gnu.org/copyleft/gpl.html > > + */ > > + > > +#include "imx27-phytec-phycore-som.dts" > > + > > +/ { > > + model = "Phytec pcm970"; > > + compatible = "phytec,imx27-pcm970", "phytec,imx27-pcm038", "fsl,imx27"; > > +}; > > + > > +&cspi1 { > > + fsl,spi-num-chipselects = <2>; > > + cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>; > > +}; > > The first chipselect connects to the mc13783 PMIC which is on the > module, not on the baseboard. Also this is a no-op since the status > property of the cspi is not changed to 'okay'. > I suspect you already have a patch adding mc13783 support to the module > which should be in this series ;) MC13783 is already here. See my previous patch for this SOM: http://www.spinics.net/lists/arm-kernel/msg240873.html ---
On Sat, Jun 01, 2013 at 12:05:57PM +0400, Alexander Shiyan wrote: > > On Sat, Jun 01, 2013 at 09:54:13AM +0400, Alexander Shiyan wrote: > > > Patch adds initial dts for Phytec PCM970 Rapid development kit. > > > - Added definition for UART0 and UART1. > > > - Added additional SPI chipselect which used on RDK for ZegBee module. > > > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > > --- > > > arch/arm/boot/dts/Makefile | 1 + > > > arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 29 ++++++++++++++++++++++++++ > > > 2 files changed, 30 insertions(+) > > > create mode 100644 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > > index 8450c14..eee371f 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -108,6 +108,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ > > > imx27-apf27dev.dtb \ > > > imx27-pdk.dtb \ > > > imx27-phytec-phycore-som.dtb \ > > > + imx27-phytec-phycore-rdk.dtb \ > > > imx31-bug.dtb \ > > > imx51-apf51.dtb \ > > > imx51-apf51dev.dtb \ > > > diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > new file mode 100644 > > > index 0000000..f8a7a49 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > @@ -0,0 +1,29 @@ > > > +/* > > > + * The code contained herein is licensed under the GNU General Public > > > + * License. You may obtain a copy of the GNU General Public License > > > + * Version 2 or later at the following locations: > > > + * > > > + * http://www.opensource.org/licenses/gpl-license.html > > > + * http://www.gnu.org/copyleft/gpl.html > > > + */ > > > + > > > +#include "imx27-phytec-phycore-som.dts" > > > + > > > +/ { > > > + model = "Phytec pcm970"; > > > + compatible = "phytec,imx27-pcm970", "phytec,imx27-pcm038", "fsl,imx27"; > > > +}; > > > + > > > +&cspi1 { > > > + fsl,spi-num-chipselects = <2>; > > > + cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>; > > > +}; > > > > The first chipselect connects to the mc13783 PMIC which is on the > > module, not on the baseboard. Also this is a no-op since the status > > property of the cspi is not changed to 'okay'. > > I suspect you already have a patch adding mc13783 support to the module > > which should be in this series ;) > > MC13783 is already here. See my previous patch for this SOM: > http://www.spinics.net/lists/arm-kernel/msg240873.html Ah, nice. I didn't remember that. In this case you can get my: Acked-by: Sascha Hauer <s.hauer@pengutronix.de> for this series Sascha
> > On Sat, Jun 01, 2013 at 09:54:13AM +0400, Alexander Shiyan wrote: > > > Patch adds initial dts for Phytec PCM970 Rapid development kit. > > > - Added definition for UART0 and UART1. > > > - Added additional SPI chipselect which used on RDK for ZegBee module. > > > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > > --- > > > arch/arm/boot/dts/Makefile | 1 + > > > arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 29 ++++++++++++++++++++++++++ > > > 2 files changed, 30 insertions(+) > > > create mode 100644 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > > index 8450c14..eee371f 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -108,6 +108,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ > > > imx27-apf27dev.dtb \ > > > imx27-pdk.dtb \ > > > imx27-phytec-phycore-som.dtb \ > > > + imx27-phytec-phycore-rdk.dtb \ > > > imx31-bug.dtb \ > > > imx51-apf51.dtb \ > > > imx51-apf51dev.dtb \ > > > diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > new file mode 100644 > > > index 0000000..f8a7a49 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts > > > @@ -0,0 +1,29 @@ > > > +/* > > > + * The code contained herein is licensed under the GNU General Public > > > + * License. You may obtain a copy of the GNU General Public License > > > + * Version 2 or later at the following locations: > > > + * > > > + * http://www.opensource.org/licenses/gpl-license.html > > > + * http://www.gnu.org/copyleft/gpl.html > > > + */ > > > + > > > +#include "imx27-phytec-phycore-som.dts" > > > + > > > +/ { > > > + model = "Phytec pcm970"; > > > + compatible = "phytec,imx27-pcm970", "phytec,imx27-pcm038", "fsl,imx27"; > > > +}; > > > + > > > +&cspi1 { > > > + fsl,spi-num-chipselects = <2>; > > > + cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>; > > > +}; > > > > The first chipselect connects to the mc13783 PMIC which is on the > > module, not on the baseboard. Also this is a no-op since the status > > property of the cspi is not changed to 'okay'. > > I suspect you already have a patch adding mc13783 support to the module > > which should be in this series ;) > > MC13783 is already here. See my previous patch for this SOM: > http://www.spinics.net/lists/arm-kernel/msg240873.html I have given you a wrong link. Sorry. This is a patch for MC13783 regulator. Here is a patch for add dt-node to the module: http://comments.gmane.org/gmane.linux.ports.arm.kernel/234757 ---
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 8450c14..eee371f 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -108,6 +108,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ imx27-apf27dev.dtb \ imx27-pdk.dtb \ imx27-phytec-phycore-som.dtb \ + imx27-phytec-phycore-rdk.dtb \ imx31-bug.dtb \ imx51-apf51.dtb \ imx51-apf51dev.dtb \ diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts new file mode 100644 index 0000000..f8a7a49 --- /dev/null +++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts @@ -0,0 +1,29 @@ +/* + * The code contained herein is licensed under the GNU General Public + * License. You may obtain a copy of the GNU General Public License + * Version 2 or later at the following locations: + * + * http://www.opensource.org/licenses/gpl-license.html + * http://www.gnu.org/copyleft/gpl.html + */ + +#include "imx27-phytec-phycore-som.dts" + +/ { + model = "Phytec pcm970"; + compatible = "phytec,imx27-pcm970", "phytec,imx27-pcm038", "fsl,imx27"; +}; + +&cspi1 { + fsl,spi-num-chipselects = <2>; + cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>; +}; + +&uart1 { + fsl,uart-has-rtscts; +}; + +&uart2 { + fsl,uart-has-rtscts; + status = "okay"; +};
Patch adds initial dts for Phytec PCM970 Rapid development kit. - Added definition for UART0 and UART1. - Added additional SPI chipselect which used on RDK for ZegBee module. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 29 ++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts