@@ -108,9 +108,9 @@ int atags_to_fdt(void *atag_list, void *fdt, int total_space)
return 0;
/* validate the ATAG */
- if (atag->hdr.tag != ATAG_CORE ||
- (atag->hdr.size != tag_size(tag_core) &&
- atag->hdr.size != 2))
+ if (atag->hdr.tag != cpu_to_atag32(ATAG_CORE) ||
+ (atag->hdr.size != cpu_to_atag32(tag_size(tag_core)) &&
+ atag->hdr.size != cpu_to_atag32(2)))
return 1;
/* let's give it all the room it could need */
@@ -119,7 +119,7 @@ int atags_to_fdt(void *atag_list, void *fdt, int total_space)
return ret;
for_each_tag(atag, atag_list) {
- if (atag->hdr.tag == ATAG_CMDLINE) {
+ if (atag->hdr.tag == cpu_to_atag32(ATAG_CMDLINE)) {
/* Append the ATAGS command line to the device tree
* command line.
* NB: This means that if the same parameter is set in
@@ -132,17 +132,17 @@ int atags_to_fdt(void *atag_list, void *fdt, int total_space)
else
setprop_string(fdt, "/chosen", "bootargs",
atag->u.cmdline.cmdline);
- } else if (atag->hdr.tag == ATAG_MEM) {
+ } else if (atag->hdr.tag == cpu_to_atag32(ATAG_MEM)) {
if (memcount >= sizeof(mem_reg_property)/4)
continue;
- if (!atag->u.mem.size)
+ if (!atag32_to_cpu(atag->u.mem.size))
continue;
- mem_reg_property[memcount++] = cpu_to_fdt32(atag->u.mem.start);
- mem_reg_property[memcount++] = cpu_to_fdt32(atag->u.mem.size);
- } else if (atag->hdr.tag == ATAG_INITRD2) {
+ mem_reg_property[memcount++] = cpu_to_fdt32(atag32_to_cpu(atag->u.mem.start));
+ mem_reg_property[memcount++] = cpu_to_fdt32(atag32_to_cpu(atag->u.mem.size));
+ } else if (atag->hdr.tag == cpu_to_atag32(ATAG_INITRD2)) {
uint32_t initrd_start, initrd_size;
- initrd_start = atag->u.initrd.start;
- initrd_size = atag->u.initrd.size;
+ initrd_start = atag32_to_cpu(atag->u.initrd.start);
+ initrd_size = atag32_to_cpu(atag->u.initrd.size);
setprop_cell(fdt, "/chosen", "linux,initrd-start",
initrd_start);
setprop_cell(fdt, "/chosen", "linux,initrd-end",
The atag-to-fdt code can now use the conversion function we introduced previously to avoid it having to know about the endian-ness of the environment which booted the processor. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/boot/compressed/atags_to_fdt.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)