From patchwork Mon Jun 24 20:41:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 2773601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 82DC1C0AB1 for ; Mon, 24 Jun 2013 20:43:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 86B6420219 for ; Mon, 24 Jun 2013 20:43:19 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FA2B2020A for ; Mon, 24 Jun 2013 20:43:18 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrDb8-0001Uv-FT; Mon, 24 Jun 2013 20:42:50 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrDav-0004kr-KT; Mon, 24 Jun 2013 20:42:37 +0000 Received: from mail-qc0-x249.google.com ([2607:f8b0:400d:c01::249]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrDat-0004jz-8p for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2013 20:42:35 +0000 Received: by mail-qc0-f201.google.com with SMTP id u11so1302070qcx.2 for ; Mon, 24 Jun 2013 13:42:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=SDkyWlqTXtSGpufx9gZi+wFSt5Rh8rN59NFu3c3Pm/g=; b=AGWyMI5usSraNV62df3+64Mj/Vg3tl5znCLU98B+uTGGO/1yPKkJQUdoFKVi8cY414 zQkss+cjxpG0ymaYO/axlqa98pvgK/ZB5TFkMMTu4pxqCYYPbXhca30lI1dXVZHHlMqr MBZjBFAjeWAJzawt8LZC+AvHEJdi8YGF+iGjXBK5B+79IjEkLTaJiCR5j1sGk8lcXLCZ qIdr4akllL8k4SIsrv42xA0lJn3jJvDAZqbXEaGiRFLU+Gu/B3yP0Ozn3IDCii0NL4nw iq6iLTS8fvyzhqNOLzrx5iPqtB6MU3Q75AHj9/Yyln0y8orHvKpjjH8xzLbq56rPN1ia qHCQ== X-Received: by 10.236.133.235 with SMTP id q71mr14650553yhi.13.1372106533236; Mon, 24 Jun 2013 13:42:13 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id b80si9873333yhi.2.2013.06.24.13.42.13 for (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 24 Jun 2013 13:42:13 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.162.34]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 10F4F31C0F7; Mon, 24 Jun 2013 13:42:13 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 99FE38075D; Mon, 24 Jun 2013 13:42:12 -0700 (PDT) From: Doug Anderson To: Russell King , David Brown Subject: [PATCH] ARM: Fix dtb dependency to use order-only prerequisites Date: Mon, 24 Jun 2013 13:41:57 -0700 Message-Id: <1372106517-19105-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.8.3 X-Gm-Message-State: ALoCoQkZpWxp/GT+fa4d1wJSvT28zd0tYScyPBzWBhxkYo/Fq34s+ZAAImqnq97jriTMY1rKEENpUn67jIJ6TvluLhsygb6BHHLhQ9DsVg7h+u2tGurEj30Xwyv9s5ZgMfQLwlZg5J1uGMeTja9BthOpJiAF2R+AFBvSUObgiZgBGbgLt/6BDrsVv879OcB7/BNo2LpgEcJeAS0yScmrNgFKutf1zS6/ow== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130624_164235_348003_749C42F9 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -3.0 (---) Cc: Russell King , Doug Anderson , linux-kernel@vger.kernel.org, Olof Johansson , Mike Frysinger , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The %.dtb dependency is specified to depend on the PHONY "scripts". That means that it'll build every time even if the underlying dtb file hasn't been touched. Use an order-only prerequisites to fix this. Also mark "dtbs" as PHONY for correctness. This was broken in (70b0476 ARM: 7513/1: Make sure dtc is built before running it). Reported-by: Mike Frysinger Signed-off-by: Doug Anderson Acked-by: Olof Johansson Reviewed-by: David Brown --- arch/arm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 1ba358b..fe8144e 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -289,9 +289,10 @@ zImage Image xipImage bootpImage uImage: vmlinux zinstall uinstall install: vmlinux $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@ -%.dtb: scripts +%.dtb: | scripts $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@ +PHONY += dtbs dtbs: scripts $(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) dtbs