diff mbox

[2/3] ARM: dts: mx28: Provide a codec clock

Message ID 1372168801-4221-2-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam June 25, 2013, 2 p.m. UTC 
Since commit 9e13f345887 (ASoC: sgtl5000: Let the codec acquire its clock) it is 
necessary to pass a codec clock to the sgtl5000 driver.

Since the saif mclk cannot be passed as a real clock within the clock framework,
let's pass a dummy one to the codec driver.

The mxs-saif driver will activate the codec clock.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx28-apx4devkit.dts | 2 +-
 arch/arm/boot/dts/imx28-evk.dts        | 2 +-
 arch/arm/boot/dts/imx28-m28evk.dts     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Mike Turquette June 25, 2013, 5:27 p.m. UTC | #1 
Quoting Shawn Guo (2013-06-25 07:22:58)
> On Tue, Jun 25, 2013 at 11:00:00AM -0300, Fabio Estevam wrote:
> > Since commit 9e13f345887 (ASoC: sgtl5000: Let the codec acquire its clock) it is 
> > necessary to pass a codec clock to the sgtl5000 driver.
> > 
> > Since the saif mclk cannot be passed as a real clock within the clock framework,
> > let's pass a dummy one to the codec driver.
> > 
> Why can not saif driver register the mclk to clock framework?

There are a growing number of drivers which define their own clocks. One
example can be found in drivers/media/platform/omap3isp/isp.c.

Regards,
Mike

> 
> Shawn
> 
> > The mxs-saif driver will activate the codec clock.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
index 43bf3c7..f26bf2f 100644
--- a/arch/arm/boot/dts/imx28-apx4devkit.dts
+++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
@@ -147,7 +147,7 @@ 
 					reg = <0x0a>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
-
+					clocks = <&clks 65>;
 				};
 
 				pcf8563: rtc@51 {
diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
index 3637bf3..28f20b6 100644
--- a/arch/arm/boot/dts/imx28-evk.dts
+++ b/arch/arm/boot/dts/imx28-evk.dts
@@ -193,7 +193,7 @@ 
 					reg = <0x0a>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
-
+					clocks = <&clks 65>;
 				};
 
 				at24@51 {
diff --git a/arch/arm/boot/dts/imx28-m28evk.dts b/arch/arm/boot/dts/imx28-m28evk.dts
index 880df2f..a09c5bf 100644
--- a/arch/arm/boot/dts/imx28-m28evk.dts
+++ b/arch/arm/boot/dts/imx28-m28evk.dts
@@ -184,7 +184,7 @@ 
 					reg = <0x0a>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
-
+					clocks = <&clks 65>;
 				};
 
 				eeprom: eeprom@51 {