| Message ID | 1372797539-13111-3-git-send-email-lho@apm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 02, 2013 at 02:38:59PM -0600, Loc Ho wrote: > power: arm64: Add DTS entry for APM X-Gene reboot driver. > > Signed-off-by: Loc Ho <lho@apm.com> > Signed-off-by: Feng Kan <fkan@apm.com> > Signed-off-by: Kumar Sankaran <ksankaran@apm.com> > --- I've applied patch 1/2 to battery-2.6.git tree. I need an ack from ARM maintainers to grab this together with the first one. > arch/arm64/boot/dts/apm-storm.dtsi | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi > index d37d736..e686919 100644 > --- a/arch/arm64/boot/dts/apm-storm.dtsi > +++ b/arch/arm64/boot/dts/apm-storm.dtsi > @@ -178,6 +178,12 @@ > }; > }; > > + reboot@0x17000014 { > + compatible = "apm,xgene-reboot"; > + reg = <0x0 0x17000014 0x0 0x100>; > + mask = <0x1>; > + }; There should be tabs instead of whitespaces. > + > serial0: serial@1c020000 { > device_type = "serial"; > compatible = "ns16550"; > -- > 1.5.5
On Fri, Aug 9, 2013 at 2:31 PM, Anton Vorontsov <anton@enomsg.org> wrote: > On Tue, Jul 02, 2013 at 02:38:59PM -0600, Loc Ho wrote: >> power: arm64: Add DTS entry for APM X-Gene reboot driver. >> >> Signed-off-by: Loc Ho <lho@apm.com> >> Signed-off-by: Feng Kan <fkan@apm.com> >> Signed-off-by: Kumar Sankaran <ksankaran@apm.com> >> --- > > I've applied patch 1/2 to battery-2.6.git tree. I need an ack from ARM > maintainers to grab this together with the first one. > >> arch/arm64/boot/dts/apm-storm.dtsi | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi >> index d37d736..e686919 100644 >> --- a/arch/arm64/boot/dts/apm-storm.dtsi >> +++ b/arch/arm64/boot/dts/apm-storm.dtsi >> @@ -178,6 +178,12 @@ >> }; >> }; >> >> + reboot@0x17000014 { >> + compatible = "apm,xgene-reboot"; >> + reg = <0x0 0x17000014 0x0 0x100>; >> + mask = <0x1>; >> + }; > > There should be tabs instead of whitespaces. Binding is undocumented, as far as I can tell. Please add documentation of this under Documentation/devicetree/bindings. In particular, the 'mask' property is nonstandard and it needs to be documented what part of the reboot controller hardware it is describing. -Olof
diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index d37d736..e686919 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -178,6 +178,12 @@ }; }; + reboot@0x17000014 { + compatible = "apm,xgene-reboot"; + reg = <0x0 0x17000014 0x0 0x100>; + mask = <0x1>; + }; + serial0: serial@1c020000 { device_type = "serial"; compatible = "ns16550";