| Message ID | 1372876601-23881-4-git-send-email-khilman@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 03, 2013 at 11:36:41AM -0700, Kevin Hilman wrote: > With the 64-bit requirement removed from virt CPU accounting, > allow ARM platforms to enable it. > > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Kevin Hilman <khilman@linaro.org> > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 136f263..7850612 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -61,6 +61,7 @@ config ARM > select OLD_SIGSUSPEND3 > select OLD_SIGACTION > select HAVE_CONTEXT_TRACKING > + select HAVE_VIRT_CPU_ACCOUNTING I think you got confused here. HAVE_VIRT_CPU_ACCOUNTING is the arch capability for VIRT_CPU_ACCOUNTING_NATIVE, not for VIRT_CPU_ACCOUNTING_GEN that only requires support for context tracking. That's my bad, all those names start to be confusing now. The VIRT based Kconfig naming is a bit weird, that doesn't really reflect what the feature is doing. "Virtual cputime accounting" just doesn't give any clue, except perhaps suggesting the stuff deals with virtualization while it actually has nothing to do with. I don't even know what virtual refers to here. Same goes for vtime based APIs. In fact I just based my work on the legacy that was there and expanded further the non-sense ;-) I'll need to do a big renaming one day. But to begin with I should rename s/HAVE_VIRT_CPU_ACCOUNTING/HAVE_VIRT_CPU_ACCOUNTING_NATIVE. > help > The ARM series is a line of low-power-consumption RISC chip designs > licensed by ARM Ltd and targeted at embedded applications and > -- > 1.8.3 >
Frederic Weisbecker <fweisbec@gmail.com> writes: > On Wed, Jul 03, 2013 at 11:36:41AM -0700, Kevin Hilman wrote: >> With the 64-bit requirement removed from virt CPU accounting, >> allow ARM platforms to enable it. >> >> Cc: Russell King <rmk+kernel@arm.linux.org.uk> >> Signed-off-by: Kevin Hilman <khilman@linaro.org> >> --- >> arch/arm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 136f263..7850612 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -61,6 +61,7 @@ config ARM >> select OLD_SIGSUSPEND3 >> select OLD_SIGACTION >> select HAVE_CONTEXT_TRACKING >> + select HAVE_VIRT_CPU_ACCOUNTING > > I think you got confused here. HAVE_VIRT_CPU_ACCOUNTING is the arch capability > for VIRT_CPU_ACCOUNTING_NATIVE, not for VIRT_CPU_ACCOUNTING_GEN that only requires > support for context tracking. Yes, I am confused. :/ > That's my bad, all those names start to be confusing now. > The VIRT based Kconfig naming is a bit weird, that doesn't really reflect what the feature > is doing. "Virtual cputime accounting" just doesn't give any clue, except perhaps suggesting > the stuff deals with virtualization while it actually has nothing to do with. > I don't even know what virtual refers to here. > > Same goes for vtime based APIs. In fact I just based my work on the legacy that was > there and expanded further the non-sense ;-) > > I'll need to do a big renaming one day. > > But to begin with I should rename s/HAVE_VIRT_CPU_ACCOUNTING/HAVE_VIRT_CPU_ACCOUNTING_NATIVE. OK, I just tested and I can indeed drop this patch. Thanks for clarifying, Kevin
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 136f263..7850612 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -61,6 +61,7 @@ config ARM select OLD_SIGSUSPEND3 select OLD_SIGACTION select HAVE_CONTEXT_TRACKING + select HAVE_VIRT_CPU_ACCOUNTING help The ARM series is a line of low-power-consumption RISC chip designs licensed by ARM Ltd and targeted at embedded applications and
With the 64-bit requirement removed from virt CPU accounting, allow ARM platforms to enable it. Cc: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Kevin Hilman <khilman@linaro.org> --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)