| Message ID | 1373021097-32420-5-git-send-email-hdoyu@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/05/2013 04:44 AM, Hiroshi Doyu wrote: > This is a bitmap that indicates which HardWare Accelerators(HWA) are > supported on Tegra30 SoC. > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > + nvidia,swgroup = TEGRA30_SWGROUP_ALL; That property isn't in the binding document. We can't add properties that aren't documented. Macros should not include structural syntax; the < > around the cell value is part of the macro the way you've written it, but shouldn't be. It'd be simpler to just write: nvidia,swgroup = <0x00000000 0x000779ff>; We should only extend the binding in a backwards-compatible fashion, so we can't require that DTs contain this value. At least, there should be a default value defined for when the property doesn't exist.
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index d8783f0..4a9594e 100644 --- a/arch/arm/boot/dts/tegra30.dtsi +++ b/arch/arm/boot/dts/tegra30.dtsi @@ -1,6 +1,7 @@ #include <dt-bindings/clock/tegra30-car.h> #include <dt-bindings/gpio/tegra-gpio.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/memory/tegra-swgroup.h> #include "skeleton.dtsi" @@ -461,6 +462,7 @@ 0x7000f228 0x05c>; nvidia,#asids = <4>; /* # of ASIDs */ dma-window = <0 0x40000000>; /* IOVA start & length */ + nvidia,swgroup = TEGRA30_SWGROUP_ALL; nvidia,ahb = <&ahb>; };
This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra30 SoC. Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com> --- arch/arm/boot/dts/tegra30.dtsi | 2 ++ 1 file changed, 2 insertions(+)