| Message ID | 1373031909-16178-1-git-send-email-mpa@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 05, 2013 at 03:45:09PM +0200, Markus Pargmann wrote: > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e The commit ID is not stable. I just dropped it and applied the patch. Shawn > "ARM: dts: Add device tree support for phycard pca100". > > Remove wrong I2C RTC node. > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > > Thanks, Alexander, you are right. I2C2 has no RTC. > > Regards, > > Markus > > arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts > index ec52b6d..01ee807 100644 > --- a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts > +++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts > @@ -55,11 +55,6 @@ > reg = <0x4a>; > }; > > - rtc@51 { > - compatible = "nxp,pcf8563"; > - reg = <0x51>; > - }; > - > at24@52 { > compatible = "at,24c32"; > pagesize = <32>; > -- > 1.8.2.1 >
> Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e > "ARM: dts: Add device tree support for phycard pca100". > > Remove wrong I2C RTC node. > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > > Thanks, Alexander, you are right. I2C2 has no RTC. ... There are a couple of comments on this file. I think that the OWIRE should be moved to the RDK. ioexpander must contain "gpio-controller" at least, and for use it further, it is necessary to define the label for this node. Thanks. ---
On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote: > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e > > "ARM: dts: Add device tree support for phycard pca100". > > > > Remove wrong I2C RTC node. > > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > --- > > > > Thanks, Alexander, you are right. I2C2 has no RTC. > ... > > There are a couple of comments on this file. > > I think that the OWIRE should be moved to the RDK. I moved OWIRE and i2c1 to RDK. Both are not used on the SOM. > ioexpander must contain "gpio-controller" at least, and for use it further, > it is necessary to define the label for this node. I checked all I2C devices in the board schematics. There is actually no ioexpander. I don't know why it was added. I will send some I2C patches later. Regards, Markus
> On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote: > > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e > > > "ARM: dts: Add device tree support for phycard pca100". > > > > > > Remove wrong I2C RTC node. > > > > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > > --- > > > > > > Thanks, Alexander, you are right. I2C2 has no RTC. > > ... > > > > There are a couple of comments on this file. > > > > I think that the OWIRE should be moved to the RDK. > > I moved OWIRE and i2c1 to RDK. Both are not used on the SOM. > > > ioexpander must contain "gpio-controller" at least, and for use it further, > > it is necessary to define the label for this node. > > I checked all I2C devices in the board schematics. There is actually no > ioexpander. I don't know why it was added. I will send some I2C patches > later. Perhaps the chip is mounted on the camera module. A similar IC is exist on PCM-970 camera addon device. If so, the device should also be moved to RDK. ---
On Sun, Jul 07, 2013 at 02:31:41PM +0400, Alexander Shiyan wrote: > > On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote: > > > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e > > > > "ARM: dts: Add device tree support for phycard pca100". > > > > > > > > Remove wrong I2C RTC node. > > > > > > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > > > --- > > > > > > > > Thanks, Alexander, you are right. I2C2 has no RTC. > > > ... > > > > > > There are a couple of comments on this file. > > > > > > I think that the OWIRE should be moved to the RDK. > > > > I moved OWIRE and i2c1 to RDK. Both are not used on the SOM. > > > > > ioexpander must contain "gpio-controller" at least, and for use it further, > > > it is necessary to define the label for this node. > > > > I checked all I2C devices in the board schematics. There is actually no > > ioexpander. I don't know why it was added. I will send some I2C patches > > later. > > Perhaps the chip is mounted on the camera module. > A similar IC is exist on PCM-970 camera addon device. > If so, the device should also be moved to RDK. Yes that's possible. But in that case I think the ioexpander should be removed from both dts files because the Phytec phyCARD-S RDK does not include a camera module. Regards, Markus
diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts index ec52b6d..01ee807 100644 --- a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts +++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts @@ -55,11 +55,6 @@ reg = <0x4a>; }; - rtc@51 { - compatible = "nxp,pcf8563"; - reg = <0x51>; - }; - at24@52 { compatible = "at,24c32"; pagesize = <32>;
Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e "ARM: dts: Add device tree support for phycard pca100". Remove wrong I2C RTC node. Signed-off-by: Markus Pargmann <mpa@pengutronix.de> --- Thanks, Alexander, you are right. I2C2 has no RTC. Regards, Markus arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 5 ----- 1 file changed, 5 deletions(-)