| Message ID | 1373379933-32749-3-git-send-email-richard.genoud@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote: > This add the sound DT binding for sam9x5ek-wm8731 machine driver > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com> > --- > .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 ++++++++++++++++++++ Put new binding documents in the same patch that reads them, this makes review easier. > + - atmel,audio-routing: A list of the connections between audio components. This needs to be more specific and list the available board specific nodes for routing. For the CODEC you can just refer to the CODEC binding documentation. > + - atmel,format: DAI format. Must be "i2s" So why not just omit this then? > + - atmel,bitclock-master: DAI clock master > + - atmel,frame-master: DAI frame master The driver isn't handling these and there's no information on how to set them.
2013/7/9 Mark Brown <broonie@kernel.org>: > On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote: >> This add the sound DT binding for sam9x5ek-wm8731 machine driver >> >> Signed-off-by: Richard Genoud <richard.genoud@gmail.com> >> --- >> .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 ++++++++++++++++++++ > > Put new binding documents in the same patch that reads them, this makes > review easier. ok, I'll squash it with patch 1 >> + - atmel,audio-routing: A list of the connections between audio components. > > This needs to be more specific and list the available board specific > nodes for routing. For the CODEC you can just refer to the CODEC > binding documentation. Ok, I'll do that. >> + - atmel,format: DAI format. Must be "i2s" > > So why not just omit this then? Will be removed. > >> + - atmel,bitclock-master: DAI clock master >> + - atmel,frame-master: DAI frame master > > The driver isn't handling these and there's no information on how to set > them. They will also go away. Thanks !
diff --git a/Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt b/Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt new file mode 100644 index 0000000..fd03dfd --- /dev/null +++ b/Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt @@ -0,0 +1,30 @@ +* Atmel at91sam9x5ek wm8731 audio complex + +Required properties: + - compatible: "atmel,at91sam9x5ek-wm8731-audio" + - atmel,model: The user-visible name of this sound complex. + - atmel,audio-routing: A list of the connections between audio components. + - atmel,ssc-controller: The phandle of the SSC controller + - atmel,audio-codec: The phandle of the WM8731 audio codec + - atmel,format: DAI format. Must be "i2s" + - atmel,bitclock-master: DAI clock master + - atmel,frame-master: DAI frame master + +Example: +sound { + compatible = "atmel,sam9x5-wm8731-audio"; + + atmel,model = "wm8731 @ AT91SAM9X5EK"; + + atmel,audio-routing = + "Headphone Jack", "RHPOUT", + "Headphone Jack", "LHPOUT", + "LLINEIN", "Line In Jack", + "RLINEIN", "Line In Jack"; + + atmel,ssc-controller = <&ssc0>; + atmel,audio-codec = <&wm8731>; + atmel,format = "i2s"; + atmel,bitclock-master; + atmel,frame-master; +};
This add the sound DT binding for sam9x5ek-wm8731 machine driver Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt