| Message ID | 1373441852-27176-1-git-send-email-ldewangan@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/10/2013 01:37 AM, Laxman Dewangan wrote: > Make the entry of Dalmore Power Management Unit device TPS65913 > in dalmore DTS file. The Palma driver support this device. > > Enable following submodule of the TPS65913: > - GPIO driver > - RTC driver. > - Power regulator driver. If I apply this, (at least) the SD card no longer works. I assume the regulator for it is being turned off somehow.
On Monday 15 July 2013 10:18 PM, Stephen Warren wrote: > On 07/10/2013 01:37 AM, Laxman Dewangan wrote: >> Make the entry of Dalmore Power Management Unit device TPS65913 >> in dalmore DTS file. The Palma driver support this device. >> >> Enable following submodule of the TPS65913: >> - GPIO driver >> - RTC driver. >> - Power regulator driver. > If I apply this, (at least) the SD card no longer works. I assume the > regulator for it is being turned off somehow. As per downstream power tree, smps9 is feeding power to sd slot and I make this rail as always ON. So there should not be any issue. Rhyland, Do you see any differences on this power tree with your power tree with DT? There was discussion sometime ago on the sdcard. Am I missing anything here? Thanks, Laxman
On 7/15/2013 1:28 PM, Laxman Dewangan wrote: > On Monday 15 July 2013 10:18 PM, Stephen Warren wrote: >> On 07/10/2013 01:37 AM, Laxman Dewangan wrote: >>> Make the entry of Dalmore Power Management Unit device TPS65913 >>> in dalmore DTS file. The Palma driver support this device. >>> >>> Enable following submodule of the TPS65913: >>> - GPIO driver >>> - RTC driver. >>> - Power regulator driver. >> If I apply this, (at least) the SD card no longer works. I assume the >> regulator for it is being turned off somehow. > > As per downstream power tree, smps9 is feeding power to sd slot and I > make this rail as always ON. So there should not be any issue. > > Rhyland, > Do you see any differences on this power tree with your power tree with > DT? There was discussion sometime ago on the sdcard. Am I missing > anything here? > > Thanks, > Laxman > I noticed a couple differences between this and what we are using... Yours: + ldo8-in-supply = <&tps65090_dcdc3_reg>; + ldo9-in-supply = <&palmas_smps9_reg>; Ours: ldo8-in-supply = <&tps65090_dcdc2_reg>; ldo9-in-supply = <&tps65090_dcdc2_reg>; We also specify supplies (floating) for smps6 and smps10. I don't think that matters though. Also we have the vmmc-supply and sd-slot-supply propeties set for the sd card slot, like so: vmmc-supply = <&palmas_smps3_reg>; sd-slot-supply = <&palmas_smps9_reg>; Also, we have the interrupt trigger mode different for the palmas: Yours: + interrupts = <0 86 0x4>; Ours: interrupts = <0 86 0x8>; I think other than that they should be the same. -Rhyland
On 07/10/2013 10:37 AM, Laxman Dewangan wrote: > Make the entry of Dalmore Power Management Unit device TPS65913 > in dalmore DTS file. The Palma driver support this device. > > Enable following submodule of the TPS65913: > - GPIO driver > - RTC driver. > - Power regulator driver. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from V1: > - renames nodes from palams_* to simple as gpio, rtc, pmic etc. > - Added line gap properly. > - Remove comment for palams-gpio reference as the entry itself explain. > - Remove unit address for tps65913. > > arch/arm/boot/dts/tegra114-dalmore.dts | 184 +++++++++++++++++++++++++++++++- > 1 files changed, 183 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts > index a42bfa4..7bdad77 100644 > --- a/arch/arm/boot/dts/tegra114-dalmore.dts > +++ b/arch/arm/boot/dts/tegra114-dalmore.dts > @@ -791,7 +791,7 @@ > regulator-boot-on; > }; > > - dcdc3 { > + tps65090_dcdc3_reg: dcdc3 { > regulator-name = "vdd-ao"; > regulator-always-on; > regulator-boot-on; > @@ -836,6 +836,178 @@ > }; > }; > }; > + > + palmas: tps65913 { > + compatible = "ti,palmas"; > + reg = <0x58>; > + interrupts = <0 86 0x4>; > + > + #interrupt-cells = <2>; > + interrupt-controller; > + > + palmas_gpio: gpio { > + compatible = "ti,palmas-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + }; I don't think the palmas-gpio driver ever gets probed since it doesn't have device tree compability strings? > ...
On 07/17/2013 11:57 AM, Laxman Dewangan wrote: > On Tuesday 16 July 2013 07:21 PM, Mikko Perttunen wrote: >> On 07/10/2013 10:37 AM, Laxman Dewangan wrote: >>> + >>> + palmas_gpio: gpio { >>> + compatible = "ti,palmas-gpio"; >>> + gpio-controller; >>> + #gpio-cells = <2>; >>> + }; >> I don't think the palmas-gpio driver ever gets probed since it doesn't >> have device tree compability strings? >> > You will need the patch > [PATCH V3] gpio: palmas: add dt support > > which is under review from last few days. > Ah, ok. I guess I'm not on the proper ML for that one.
On Tuesday 16 July 2013 07:21 PM, Mikko Perttunen wrote: > On 07/10/2013 10:37 AM, Laxman Dewangan wrote: >> + >> + palmas_gpio: gpio { >> + compatible = "ti,palmas-gpio"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + }; > I don't think the palmas-gpio driver ever gets probed since it doesn't > have device tree compability strings? > You will need the patch [PATCH V3] gpio: palmas: add dt support which is under review from last few days.
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts index a42bfa4..7bdad77 100644 --- a/arch/arm/boot/dts/tegra114-dalmore.dts +++ b/arch/arm/boot/dts/tegra114-dalmore.dts @@ -791,7 +791,7 @@ regulator-boot-on; }; - dcdc3 { + tps65090_dcdc3_reg: dcdc3 { regulator-name = "vdd-ao"; regulator-always-on; regulator-boot-on; @@ -836,6 +836,178 @@ }; }; }; + + palmas: tps65913 { + compatible = "ti,palmas"; + reg = <0x58>; + interrupts = <0 86 0x4>; + + #interrupt-cells = <2>; + interrupt-controller; + + palmas_gpio: gpio { + compatible = "ti,palmas-gpio"; + gpio-controller; + #gpio-cells = <2>; + }; + + rtc { + compatible = "ti,palmas-rtc"; + interrupt-parent = <&palmas>; + interrupts = <8 0>; + }; + + pmic { + compatible = "ti,tps65913-pmic", "ti,palmas-pmic"; + smps1-in-supply = <&tps65090_dcdc3_reg>; + smps3-in-supply = <&tps65090_dcdc3_reg>; + smps4-in-supply = <&tps65090_dcdc2_reg>; + smps7-in-supply = <&tps65090_dcdc2_reg>; + smps8-in-supply = <&tps65090_dcdc2_reg>; + smps9-in-supply = <&tps65090_dcdc2_reg>; + ldo1-in-supply = <&tps65090_dcdc2_reg>; + ldo2-in-supply = <&tps65090_dcdc2_reg>; + ldo3-in-supply = <&palmas_smps3_reg>; + ldo4-in-supply = <&tps65090_dcdc2_reg>; + ldo5-in-supply = <&vdd_ac_bat_reg>; + ldo6-in-supply = <&tps65090_dcdc2_reg>; + ldo7-in-supply = <&tps65090_dcdc2_reg>; + ldo8-in-supply = <&tps65090_dcdc3_reg>; + ldo9-in-supply = <&palmas_smps9_reg>; + ldoln-in-supply = <&tps65090_dcdc1_reg>; + ldousb-in-supply = <&tps65090_dcdc1_reg>; + + regulators { + smps12 { + regulator-name = "vddio-ddr"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + regulator-always-on; + regulator-boot-on; + }; + + palmas_smps3_reg: smps3 { + regulator-name = "vddio-1v8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + + smps45 { + regulator-name = "vdd-core"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + }; + + smps457 { + regulator-name = "vdd-core"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + }; + + smps8 { + regulator-name = "avdd-pll"; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1050000>; + regulator-always-on; + regulator-boot-on; + }; + + palmas_smps9_reg: smps9 { + regulator-name = "sdhci-vdd-sd-slot"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-always-on; + }; + + ldo1 { + regulator-name = "avdd-cam1"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + + ldo2 { + regulator-name = "avdd-cam2"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + + ldo3 { + regulator-name = "avdd-dsi-csi"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + }; + + ldo4 { + regulator-name = "vpp-fuse"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + ldo6 { + regulator-name = "vdd-sensor-2v85"; + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2850000>; + }; + + ldo7 { + regulator-name = "vdd-af-cam1"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + + ldo8 { + regulator-name = "vdd-rtc"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <900000>; + regulator-always-on; + regulator-boot-on; + ti,enable-ldo8-tracking; + }; + + ldo9 { + regulator-name = "vddio-sdmmc-2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + + ldoln { + regulator-name = "hvdd-usb"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + ldousb { + regulator-name = "avdd-usb"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + regulator-boot-on; + }; + + regen1 { + regulator-name = "rail-3v3"; + regulator-max-microvolt = <3300000>; + regulator-always-on; + regulator-boot-on; + }; + + regen2 { + regulator-name = "rail-5v0"; + regulator-max-microvolt = <5000000>; + regulator-always-on; + regulator-boot-on; + }; + }; + }; + }; }; spi@7000da00 { @@ -980,6 +1152,16 @@ gpio = <&gpio TEGRA_GPIO(K, 1) GPIO_ACTIVE_HIGH>; vin-supply = <&tps65090_dcdc1_reg>; }; + + vdd_cam_1v8_reg: regulator@6 { + compatible = "regulator-fixed"; + reg = <6>; + regulator-name = "vdd_cam_1v8_reg"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + enable-active-high; + gpio = <&palmas_gpio 6 0>; + }; }; sound {
Make the entry of Dalmore Power Management Unit device TPS65913 in dalmore DTS file. The Palma driver support this device. Enable following submodule of the TPS65913: - GPIO driver - RTC driver. - Power regulator driver. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- Changes from V1: - renames nodes from palams_* to simple as gpio, rtc, pmic etc. - Added line gap properly. - Remove comment for palams-gpio reference as the entry itself explain. - Remove unit address for tps65913. arch/arm/boot/dts/tegra114-dalmore.dts | 184 +++++++++++++++++++++++++++++++- 1 files changed, 183 insertions(+), 1 deletions(-)