pinctrl: tegra: expose config options for individual SoCs

Commit Message

Stephen Warren July 16, 2013, 10:34 p.m. UTC

From: Stephen Warren <[e-mail]>

I'm planning to remove CONFIG_ARCH_TEGRA_*_SOC, leaving just ARCH_TEGRA.
This will reduce the number of configurations that need to be supported
by core Tegra code, e.g. CPU idle, hotplug. As a precursor, we need to
update Kconfig for all Tegra drivers not to reference ARCH_TEGRA_*_SOC.

The Tegra pinctrl driver contains a fairly large amount of SoC-specific
code and data. Introduce explicit config options so that the user can
trim the set of supported SoCs if they wish. Default these to on, since
most people will probably want to enable support for all SoCs. This also
avoids the need to change any defconfig files.

Signed-off-by: Stephen Warren <[e-mail]>
---
 drivers/pinctrl/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Stephen Warren July 18, 2013, 5 p.m. UTC | #1

On 07/16/2013 04:34 PM, Stephen Warren wrote:
> I'm planning to remove CONFIG_ARCH_TEGRA_*_SOC, leaving just ARCH_TEGRA.
> This will reduce the number of configurations that need to be supported
> by core Tegra code, e.g. CPU idle, hotplug. As a precursor, we need to
> update Kconfig for all Tegra drivers not to reference ARCH_TEGRA_*_SOC.
> 
> The Tegra pinctrl driver contains a fairly large amount of SoC-specific
> code and data. Introduce explicit config options so that the user can
> trim the set of supported SoCs if they wish. Default these to on, since
> most people will probably want to enable support for all SoCs. This also
> avoids the need to change any defconfig files.

I'd like to defer actually applying this patch. There is some discussion
(in the thread for the equivalent ASoC patches) re: the best way to
handle the ARCH_TEGRA_*_SOC Kconfig options which might affect this
patch. Any review comment is still appreciated.

Linus Walleij July 26, 2013, 11:31 p.m. UTC | #2

On Thu, Jul 18, 2013 at 7:00 PM, Stephen Warren <[e-mail]> wrote:
> On 07/16/2013 04:34 PM, Stephen Warren wrote:
>> I'm planning to remove CONFIG_ARCH_TEGRA_*_SOC, leaving just ARCH_TEGRA.
>> This will reduce the number of configurations that need to be supported
>> by core Tegra code, e.g. CPU idle, hotplug. As a precursor, we need to
>> update Kconfig for all Tegra drivers not to reference ARCH_TEGRA_*_SOC.
>>
>> The Tegra pinctrl driver contains a fairly large amount of SoC-specific
>> code and data. Introduce explicit config options so that the user can
>> trim the set of supported SoCs if they wish. Default these to on, since
>> most people will probably want to enable support for all SoCs. This also
>> avoids the need to change any defconfig files.
>
> I'd like to defer actually applying this patch. There is some discussion
> (in the thread for the equivalent ASoC patches) re: the best way to
> handle the ARCH_TEGRA_*_SOC Kconfig options which might affect this
> patch. Any review comment is still appreciated.

Just poke me when the discussion settles.

I'm totally unenlightened on this issue myself so not of much
help...

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 5a8ad51..25a56b5 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -207,15 +207,21 @@  config PINCTRL_TEGRA
 	select PINCONF
 
 config PINCTRL_TEGRA20
-	bool
+	bool "NVIDIA Tegra20 pin control driver"
+	depends on ARCH_TEGRA
+	default y
 	select PINCTRL_TEGRA
 
 config PINCTRL_TEGRA30
-	bool
+	bool "NVIDIA Tegra30 pin control driver"
+	depends on ARCH_TEGRA
+	default y
 	select PINCTRL_TEGRA
 
 config PINCTRL_TEGRA114
-	bool
+	bool "NVIDIA Tegra114 pin control driver"
+	depends on ARCH_TEGRA
+	default y
 	select PINCTRL_TEGRA
 
 config PINCTRL_TZ1090