| Message ID | 1374492747-13879-4-git-send-email-Sudeep.KarkadaNagesha@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sudeep, On Monday 22 of July 2013 12:32:14 Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Acked-by: Rob Herring <rob.herring@calxeda.com> > Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> > --- > drivers/base/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 4c358bc..ea51c6d 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -14,6 +14,7 @@ > #include <linux/slab.h> > #include <linux/percpu.h> > #include <linux/acpi.h> > +#include <linux/of.h> > > #include "base.h" > > @@ -289,6 +290,7 @@ int register_cpu(struct cpu *cpu, int num) > cpu->dev.release = cpu_device_release; > cpu->dev.offline_disabled = !cpu->hotpluggable; > cpu->dev.offline = !cpu_online(num); > + cpu->dev.of_node = of_get_cpu_node(num); Aha, so this would be the only place where of_get_cpu_node() gets called, so the parsing would be done only once and then any code that needs CPU DT node would just simply grab it from CPU dev. Fair enough. Not sure if this makes the need for such helper to be globally available in of/base.c, but I guess this won't hurt. Best regards, Tomasz
On 15/08/13 12:35, Tomasz Figa wrote: > Hi Sudeep, > > On Monday 22 of July 2013 12:32:14 Sudeep KarkadaNagesha wrote: >> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> >> >> CPUs are also registered as devices but the of_node in these cpu >> devices are not initialized. Currently different drivers requiring >> to access cpu device node are parsing the nodes themselves and >> initialising the of_node in cpu device. >> >> The of_node in all the cpu devices needs to be initialized properly >> and at one place. The best place to update this is CPU subsystem >> driver when registering the cpu devices. >> >> The OF/DT core library now provides of_get_cpu_node to retrieve a cpu >> device node for a given logical index by abstracting the architecture >> specific details. >> >> This patch uses of_get_cpu_node to assign of_node when registering the >> cpu devices. >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Acked-by: Rob Herring <rob.herring@calxeda.com> >> Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> >> --- >> drivers/base/cpu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c >> index 4c358bc..ea51c6d 100644 >> --- a/drivers/base/cpu.c >> +++ b/drivers/base/cpu.c >> @@ -14,6 +14,7 @@ >> #include <linux/slab.h> >> #include <linux/percpu.h> >> #include <linux/acpi.h> >> +#include <linux/of.h> >> >> #include "base.h" >> >> @@ -289,6 +290,7 @@ int register_cpu(struct cpu *cpu, int num) >> cpu->dev.release = cpu_device_release; >> cpu->dev.offline_disabled = !cpu->hotpluggable; >> cpu->dev.offline = !cpu_online(num); >> + cpu->dev.of_node = of_get_cpu_node(num); > > Aha, so this would be the only place where of_get_cpu_node() gets called, > so the parsing would be done only once and then any code that needs CPU DT > node would just simply grab it from CPU dev. Fair enough. > > Not sure if this makes the need for such helper to be globally available > in of/base.c, but I guess this won't hurt. > Ah, you found it out yourself. Sorry responded to your earlier mail. Yes but there may be uses cases which need cpu of_node before CPUs get registered. I believe PATCH 4-6 in the series is good examples as why we need this helper to be global. Move over now we need to extend support to PowerPC where DT is scanned needlessly always to fetch cpu of_node. Of course they need to fix it, use cpu->of_node instead. Regards, Sudeep
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 4c358bc..ea51c6d 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/percpu.h> #include <linux/acpi.h> +#include <linux/of.h> #include "base.h" @@ -289,6 +290,7 @@ int register_cpu(struct cpu *cpu, int num) cpu->dev.release = cpu_device_release; cpu->dev.offline_disabled = !cpu->hotpluggable; cpu->dev.offline = !cpu_online(num); + cpu->dev.of_node = of_get_cpu_node(num); #ifdef CONFIG_ARCH_HAS_CPU_AUTOPROBE cpu->dev.bus->uevent = arch_cpu_uevent; #endif