| Message ID | 1374682733-7416-3-git-send-email-jonathan.austin@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/24/2013 06:18 PM, Jonathan Austin wrote: > Initialisation of the ARM Arch timer requires data from the DT. There is no > fallback initialisation method and hence selecting ARM_ARCH_TIMER without OF > makes little sense. > > Furthermore, doing so causes a build error because the of_* stubs for > !CONFIG_OF do not extend to all of the functions being used by this driver, > and will not be extended unless there are valid use-cases for them to be > (this is not a valid case). > > Signed-off-by: Jonathan Austin <jonathan.austin@arm.com> > --- This falls under the drivers/clocksource umbrella. Please resend to the maintainers. Thanks -- Daniel > drivers/clocksource/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index b7b9b04..4348902 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -72,7 +72,8 @@ config CLKSRC_DBX500_PRCMU_SCHED_CLOCK > > config ARM_ARCH_TIMER > bool > - select CLKSRC_OF if OF > + depends on OF > + select CLKSRC_OF > > config ARM_GLOBAL_TIMER > bool >
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index b7b9b04..4348902 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -72,7 +72,8 @@ config CLKSRC_DBX500_PRCMU_SCHED_CLOCK config ARM_ARCH_TIMER bool - select CLKSRC_OF if OF + depends on OF + select CLKSRC_OF config ARM_GLOBAL_TIMER bool
Initialisation of the ARM Arch timer requires data from the DT. There is no fallback initialisation method and hence selecting ARM_ARCH_TIMER without OF makes little sense. Furthermore, doing so causes a build error because the of_* stubs for !CONFIG_OF do not extend to all of the functions being used by this driver, and will not be extended unless there are valid use-cases for them to be (this is not a valid case). Signed-off-by: Jonathan Austin <jonathan.austin@arm.com> --- drivers/clocksource/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)