| Message ID | 1375866616-5541-2-git-send-email-padma.v@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 07, 2013 at 02:40:10PM +0530, Padmavathi Venna wrote: > This patch removes quirks from i2s node and change the i2s > compatible names. This needs to go along with the driver change otherwise we break bisection.
Hi Mark, On Wed, Aug 7, 2013 at 3:40 PM, Mark Brown <broonie@kernel.org> wrote: > On Wed, Aug 07, 2013 at 02:40:10PM +0530, Padmavathi Venna wrote: >> This patch removes quirks from i2s node and change the i2s >> compatible names. > > This needs to go along with the driver change otherwise we break > bisection. some of the patches at dts side are dependent on this patch. So I separated it into another set. Should I re-post this patch along with other driver side patches? Thanks Padma
On Wednesday 07 of August 2013 16:02:16 Padma Venkat wrote: > Hi Mark, > > On Wed, Aug 7, 2013 at 3:40 PM, Mark Brown <broonie@kernel.org> wrote: > > On Wed, Aug 07, 2013 at 02:40:10PM +0530, Padmavathi Venna wrote: > >> This patch removes quirks from i2s node and change the i2s > >> compatible names. > > > > This needs to go along with the driver change otherwise we break > > bisection. > > some of the patches at dts side are dependent on this patch. So I > separated it into another set. Should I re-post this patch along with > other driver side patches? I fully agree with Mark. There are 2 ways of solving this: a) Do things in steps that don't break anything, i.e.: 1) add new bindings to the driver, 2) update DTS files, 3) remove old bindings from the driver. b) Do all the things above atomically, in one patch. Personally, I'm a fan of method a), but if it requires much effort then method b) can be used as a fallback. Best regards, Tomasz
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 48c0a88..5b36121 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -393,7 +393,7 @@ }; i2s0: i2s@03830000 { - compatible = "samsung,i2s-v5"; + compatible = "samsung,s5pv210-i2s"; reg = <0x03830000 0x100>; dmas = <&pdma0 10 &pdma0 9 @@ -403,16 +403,13 @@ <&clock_audss EXYNOS_I2S_BUS>, <&clock_audss EXYNOS_SCLK_I2S>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; - samsung,supports-6ch; - samsung,supports-rstclr; - samsung,supports-secdai; samsung,idma-addr = <0x03000000>; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; }; i2s1: i2s@12D60000 { - compatible = "samsung,i2s-v5"; + compatible = "samsung,s3c6410-i2s"; reg = <0x12D60000 0x100>; dmas = <&pdma1 12 &pdma1 11>; @@ -424,7 +421,7 @@ }; i2s2: i2s@12D70000 { - compatible = "samsung,i2s-v5"; + compatible = "samsung,s3c6410-i2s"; reg = <0x12D70000 0x100>; dmas = <&pdma0 12 &pdma0 11>;
This patch removes quirks from i2s node and change the i2s compatible names. Signed-off-by: Padmavathi Venna <padma.v@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-)