| Message ID | 1376243970-6489-18-git-send-email-tomasz.figa@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ > config SPI_S3C64XX > tristate "Samsung S3C64XX series type SPI" > depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS) > - select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 > + select S3C64XX_PL080 if ARCH_S3C64XX > help > SPI driver for Samsung S3C64XX and newer SoCs. Do we need the select here (or should we have other selects for the Exynos SoCs)?
Hi Mark, On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: > > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ > > > > config SPI_S3C64XX > > > > tristate "Samsung S3C64XX series type SPI" > > depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || > > ARCH_EXYNOS)> > > - select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 > > + select S3C64XX_PL080 if ARCH_S3C64XX > > > > help > > > > SPI driver for Samsung S3C64XX and newer SoCs. > > Do we need the select here (or should we have other selects for the > Exynos SoCs)? The driver would build fine without this symbol selected, but since it relies on availability of DMA, it doesn't make too much sense to build it this way. This kind of selects makes kernel configuration more user friendly IMHO. Possibly adding appropriate selects (PL330) for s5p* and exynos could make sense. Best regards, Tomasz
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote: > On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: > > Do we need the select here (or should we have other selects for the > > Exynos SoCs)? > The driver would build fine without this symbol selected, but since it > relies on availability of DMA, it doesn't make too much sense to build it > this way. This kind of selects makes kernel configuration more user > friendly IMHO. > Possibly adding appropriate selects (PL330) for s5p* and exynos could make > sense. Right. On these SoCs it's probably worth doing it in the arch/arm code rather than for every device using the controller though, it's the same DMA controller for everything.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 241a049..a13867e 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ config SPI_S3C64XX tristate "Samsung S3C64XX series type SPI" depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS) - select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080 + select S3C64XX_PL080 if ARCH_S3C64XX help SPI driver for Samsung S3C64XX and newer SoCs.
The legacy S3C64xx DMA driver has been removed, DMA support on S3C64xx is provided only by the generic PL08x driver. This patch modifies the Kconfig entry of spi-s3c64xx driver, which relies on availability of DMA, to always select the S3C64XX_PL080 symbol. Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)