| Message ID | 1377225242-5854-5-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jisheng, On Fri, Aug 23, 2013 at 10:34:02AM +0800, Jisheng Zhang wrote: > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > Mmm.. I would prefer to see a better commit log for this patch. In particular, the current code is buggy (for there's a leak) and this patch fixes it. Care to write something meaningful and re-send? (except the patch Mike already took, I guess). With that changes you can add: Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>T for the whole series.
Hi Ezequiel, On Sat, 24 Aug 2013 08:06:25 -0700 Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote: > Hi Jisheng, > > On Fri, Aug 23, 2013 at 10:34:02AM +0800, Jisheng Zhang wrote: > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > --- > > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > Mmm.. I would prefer to see a better commit log for this patch. > In particular, the current code is buggy (for there's a leak) and > this patch fixes it. > Care to write something meaningful and re-send? (except the patch Done. Could you please review again? > Mike already took, I guess). > > With that changes you can add: > > Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>T Thank you for your help > > for the whole series. Best Regards, Jisheng
diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c index bb7ddb1..1caa45f 100644 --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c @@ -579,7 +579,7 @@ static int mvebu_pinctrl_build_functions(struct platform_device *pdev, int mvebu_pinctrl_probe(struct platform_device *pdev) { struct mvebu_pinctrl_soc_info *soc = dev_get_platdata(&pdev->dev); - struct device_node *np = pdev->dev.of_node; + struct resource *res; struct mvebu_pinctrl *pctl; void __iomem *base; struct pinctrl_pin_desc *pdesc; @@ -591,11 +591,10 @@ int mvebu_pinctrl_probe(struct platform_device *pdev) return -EINVAL; } - base = of_iomap(np, 0); - if (!base) { - dev_err(&pdev->dev, "unable to get base address\n"); - return -ENODEV; - } + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(base)) + return PTR_ERR(base); pctl = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_pinctrl), GFP_KERNEL);
Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)