diff mbox

ARM: multi_v7: add HREFv60 to multi_v7 defconfig

Message ID 1379334152-9751-1-git-send-email-linus.walleij@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Sept. 16, 2013, 12:22 p.m. UTC
This is just a standard board for the Ux500, include it in the
v7 multiplatform defconfig.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi ARM SoC folks: this makes also my preferred development board
boot with multi_v7. Please apply this patch directly to fixes
if you're happy with it.
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Sept. 16, 2013, 1:11 p.m. UTC | #1
On Mon, Sep 16, 2013 at 7:22 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> This is just a standard board for the Ux500, include it in the
> v7 multiplatform defconfig.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi ARM SoC folks: this makes also my preferred development board
> boot with multi_v7. Please apply this patch directly to fixes
> if you're happy with it.
> ---
>  arch/arm/configs/multi_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 6e572c6..a333753 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -36,6 +36,7 @@ CONFIG_ARCH_TEGRA_114_SOC=y
>  CONFIG_TEGRA_PCI=y
>  CONFIG_TEGRA_EMC_SCALING_ENABLE=y
>  CONFIG_ARCH_U8500=y
> +CONFIG_MACH_HREFV60=y

This option doesn't seem to actually affect the build in anyway. Same
with snowball. Why not remove them?

Rob
Rob Herring Sept. 16, 2013, 1:15 p.m. UTC | #2
On Mon, Sep 16, 2013 at 8:11 AM, Rob Herring <robherring2@gmail.com> wrote:
> On Mon, Sep 16, 2013 at 7:22 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> This is just a standard board for the Ux500, include it in the
>> v7 multiplatform defconfig.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Hi ARM SoC folks: this makes also my preferred development board
>> boot with multi_v7. Please apply this patch directly to fixes
>> if you're happy with it.
>> ---
>>  arch/arm/configs/multi_v7_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index 6e572c6..a333753 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -36,6 +36,7 @@ CONFIG_ARCH_TEGRA_114_SOC=y
>>  CONFIG_TEGRA_PCI=y
>>  CONFIG_TEGRA_EMC_SCALING_ENABLE=y
>>  CONFIG_ARCH_U8500=y
>> +CONFIG_MACH_HREFV60=y
>
> This option doesn't seem to actually affect the build in anyway. Same
> with snowball. Why not remove them?

Well, I've already forgotten how mach-types works... So the only
difference is a machine desc included or not. Why not just always
include all machines.

Rob
Russell King - ARM Linux Sept. 16, 2013, 2:41 p.m. UTC | #3
On Mon, Sep 16, 2013 at 08:15:50AM -0500, Rob Herring wrote:
> On Mon, Sep 16, 2013 at 8:11 AM, Rob Herring <robherring2@gmail.com> wrote:
> > On Mon, Sep 16, 2013 at 7:22 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> >> This is just a standard board for the Ux500, include it in the
> >> v7 multiplatform defconfig.
> >>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> Hi ARM SoC folks: this makes also my preferred development board
> >> boot with multi_v7. Please apply this patch directly to fixes
> >> if you're happy with it.
> >> ---
> >>  arch/arm/configs/multi_v7_defconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> >> index 6e572c6..a333753 100644
> >> --- a/arch/arm/configs/multi_v7_defconfig
> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >> @@ -36,6 +36,7 @@ CONFIG_ARCH_TEGRA_114_SOC=y
> >>  CONFIG_TEGRA_PCI=y
> >>  CONFIG_TEGRA_EMC_SCALING_ENABLE=y
> >>  CONFIG_ARCH_U8500=y
> >> +CONFIG_MACH_HREFV60=y
> >
> > This option doesn't seem to actually affect the build in anyway. Same
> > with snowball. Why not remove them?
> 
> Well, I've already forgotten how mach-types works... So the only
> difference is a machine desc included or not. Why not just always
> include all machines.

Looking at arch/arm/mach-ux500/board-mop500.c, the machine_desc will be
included anyway.  It's more whether machine_is_hrefv60() are defined to
be constant false or not.
Olof Johansson Sept. 16, 2013, 2:54 p.m. UTC | #4
On Mon, Sep 16, 2013 at 02:22:32PM +0200, Linus Walleij wrote:
> This is just a standard board for the Ux500, include it in the
> v7 multiplatform defconfig.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi ARM SoC folks: this makes also my preferred development board
> boot with multi_v7. Please apply this patch directly to fixes
> if you're happy with it.

Ho hum. I think the approach we want is to only do DT platforms on
multi_v7.  You have a series to drop/switch all non-DT platforms coming
soon though, I think?


-Olof
Linus Walleij Sept. 17, 2013, 9:16 a.m. UTC | #5
On Mon, Sep 16, 2013 at 4:54 PM, Olof Johansson <olof@lixom.net> wrote:
> On Mon, Sep 16, 2013 at 02:22:32PM +0200, Linus Walleij wrote:
>> This is just a standard board for the Ux500, include it in the
>> v7 multiplatform defconfig.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Hi ARM SoC folks: this makes also my preferred development board
>> boot with multi_v7. Please apply this patch directly to fixes
>> if you're happy with it.
>
> Ho hum. I think the approach we want is to only do DT platforms on
> multi_v7.  You have a series to drop/switch all non-DT platforms coming
> soon though, I think?

Yes and yes. But the patch was intended for the v3.12-rcs to be
usable.

Yours,
Linus Walleij
Olof Johansson Sept. 18, 2013, 7:15 p.m. UTC | #6
On Tue, Sep 17, 2013 at 11:16:10AM +0200, Linus Walleij wrote:
> On Mon, Sep 16, 2013 at 4:54 PM, Olof Johansson <olof@lixom.net> wrote:
> > On Mon, Sep 16, 2013 at 02:22:32PM +0200, Linus Walleij wrote:
> >> This is just a standard board for the Ux500, include it in the
> >> v7 multiplatform defconfig.
> >>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> Hi ARM SoC folks: this makes also my preferred development board
> >> boot with multi_v7. Please apply this patch directly to fixes
> >> if you're happy with it.
> >
> > Ho hum. I think the approach we want is to only do DT platforms on
> > multi_v7.  You have a series to drop/switch all non-DT platforms coming
> > soon though, I think?
> 
> Yes and yes. But the patch was intended for the v3.12-rcs to be
> usable.

Well, since snowball is already enabled I suppose we can take this
too. It should maybe never have been enabled, but that's water under the bridge
since it'll all be switched by 3.13.


-Olof
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 6e572c6..a333753 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -36,6 +36,7 @@  CONFIG_ARCH_TEGRA_114_SOC=y
 CONFIG_TEGRA_PCI=y
 CONFIG_TEGRA_EMC_SCALING_ENABLE=y
 CONFIG_ARCH_U8500=y
+CONFIG_MACH_HREFV60=y
 CONFIG_MACH_SNOWBALL=y
 CONFIG_MACH_UX500_DT=y
 CONFIG_ARCH_VEXPRESS=y