From patchwork Mon Sep 30 21:03:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 2966921 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 159529F289 for ; Mon, 30 Sep 2013 21:05:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 04CAF2022F for ; Mon, 30 Sep 2013 21:05:51 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A6EF20204 for ; Mon, 30 Sep 2013 21:05:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQkeA-0007fp-2n; Mon, 30 Sep 2013 21:04:50 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQkdn-0007Cw-Vt; Mon, 30 Sep 2013 21:04:27 +0000 Received: from top.free-electrons.com ([176.31.233.9] helo=mail.free-electrons.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VQkdI-00079Y-L2 for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2013 21:03:57 +0000 Received: by mail.free-electrons.com (Postfix, from userid 106) id 758568DB; Mon, 30 Sep 2013 23:03:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost.localdomain (unknown [190.2.109.158]) by mail.free-electrons.com (Postfix) with ESMTPA id 55C69147; Mon, 30 Sep 2013 23:03:39 +0200 (CEST) From: Ezequiel Garcia To: Subject: [PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks Date: Mon, 30 Sep 2013 18:03:29 -0300 Message-Id: <1380575010-8573-4-git-send-email-ezequiel.garcia@free-electrons.com> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: <1380575010-8573-1-git-send-email-ezequiel.garcia@free-electrons.com> References: <1380575010-8573-1-git-send-email-ezequiel.garcia@free-electrons.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130930_170356_826801_64B4E6AC X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) Cc: Thomas Petazzoni , Andrew Lunn , Mike Turquette , Jason Cooper , Jason Gunthorpe , Ezequiel Garcia , Gregory Clement , Sebastian Hesselbarth X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP These clocks should never be gated, since the ethernet interfaces forget the assigned MAC address assigned if their clock source is turned off. Signed-off-by: Ezequiel Garcia --- Cc: Mike Turquette drivers/clk/mvebu/kirkwood.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c index 2636a55..69d9603 100644 --- a/drivers/clk/mvebu/kirkwood.c +++ b/drivers/clk/mvebu/kirkwood.c @@ -220,7 +220,12 @@ CLK_OF_DECLARE(mv88f6180_core_clk, "marvell,mv88f6180-core-clock", */ static const struct clk_gating_soc_desc kirkwood_gating_desc[] __initconst = { - { "ge0", NULL, 0, 0 }, + /* + * The ethernet interfaces forget their assigned MAC address + * if the clocks are turned off. Until proper DT support + * is available we prevent ge0 and ge1 gating for now. + */ + { "ge0", NULL, 0, CLK_IGNORE_UNUSED }, { "pex0", NULL, 2, 0 }, { "usb0", NULL, 3, 0 }, { "sdio", NULL, 4, 0 }, @@ -234,7 +239,7 @@ static const struct clk_gating_soc_desc kirkwood_gating_desc[] __initconst = { { "xor1", NULL, 16, 0 }, { "crypto", NULL, 17, 0 }, { "pex1", NULL, 18, 0 }, - { "ge1", NULL, 19, 0 }, + { "ge1", NULL, 19, CLK_IGNORE_UNUSED }, { "tdm", NULL, 20, 0 }, { } };