From patchwork Thu Oct 3 05:05:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 2980841 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2EF7ABFF0B for ; Thu, 3 Oct 2013 05:06:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 963A920174 for ; Thu, 3 Oct 2013 05:05:57 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B94A12026D for ; Thu, 3 Oct 2013 05:05:56 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRb6g-0003f9-UP; Thu, 03 Oct 2013 05:05:47 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRb6e-0007xx-Ie; Thu, 03 Oct 2013 05:05:44 +0000 Received: from mail-pb0-x230.google.com ([2607:f8b0:400e:c01::230]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRb6c-0007x5-AQ for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2013 05:05:42 +0000 Received: by mail-pb0-f48.google.com with SMTP id ma3so1905253pbc.35 for ; Wed, 02 Oct 2013 22:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=LRpEX/d4XJD71GL/MVuM8S+j/Z9B+IhKEmwafxRBFV8=; b=eLWpkR58B7zwVC6a3v+xlNMRDSSyn6lHUIg4NFNtCUcigBlhuOAzWyHZZxHai9QvgO oz9PH9u38KigwwoaoX8GLEbTHCrAes1sSljkMq51XQYqFClCXb08/pD7yT7y1RmyixN3 bQct81gzyq1t5UD5GoFOqadV3F2oId6vol3Aue1oiC/wtgGJXRuIaMzTLaxNlaELjLIT jgIKhGPJq3jlCxJjCXZrA9s/GmBAske6OfQfsXeBkDaoEplis6RwTGWyZM/Iu7NAtZ5n lfuaRQRXjKlErlfIDDkpcZTHDM7gKog9J0xPMFWyaL9vNJULPVQMthd9SB964+ZfemNv Ow+A== X-Received: by 10.68.173.5 with SMTP id bg5mr6560922pbc.26.1380776720594; Wed, 02 Oct 2013 22:05:20 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id k4sm5574202pbd.11.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 02 Oct 2013 22:05:19 -0700 (PDT) From: Guenter Roeck To: linux-omap@vger.kernel.org Subject: [PATCH] arm: Select NOP_USB_XCEIV if MACH_OMAP3EVM is enabled Date: Wed, 2 Oct 2013 22:05:10 -0700 Message-Id: <1380776710-27788-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.7.9.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131003_010542_452267_8F418125 X-CRM114-Status: GOOD ( 11.01 ) X-Spam-Score: 0.9 (/) Cc: Tony Lindgren , Guenter Roeck , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,SUSPICIOUS_RECIPS,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP arm builds have been failing on and off with arch/arm/mach-omap2/board-omap3evm.c:703: undefined reference to `usb_nop_xceiv_register' for several years. Current arm:allmodconfig build fails for this reason. Problem is that board-omap3evm.c is always build into the kernel. It calls usb_nop_xceiv_register(), which is built with NOP_USB_XCEIV, which in turn can be configured as module. This results in the observed build failure. Fix the problem once and for all by selecting NOP_USB_XCEIV if MACH_OMAP3EVM is enabled. Signed-off-by: Guenter Roeck --- arch/arm/mach-omap2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index b5fb5f7..0bc2cf4 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -265,6 +265,7 @@ config MACH_OMAP3EVM depends on ARCH_OMAP3 default y select OMAP_PACKAGE_CBB + select NOP_USB_XCEIV config MACH_OMAP3517EVM bool "OMAP3517/ AM3517 EVM board"